Skip to content

Switch CLA action to Node 24 fork v2.7.1#20

Merged
iainmcgin merged 1 commit intomainfrom
chore/cla-action-fork-v2.7.1
Mar 30, 2026
Merged

Switch CLA action to Node 24 fork v2.7.1#20
iainmcgin merged 1 commit intomainfrom
chore/cla-action-fork-v2.7.1

Conversation

@iainmcgin
Copy link
Copy Markdown
Collaborator

Swaps the CLA workflow from the archived upstream contributor-assistant/github-action@v2.6.1 to the forked iainmcgin/cla-github-action at v2.7.1. Brings connect-rust to parity with buffa (which adopted v2.7.0 in anthropics/buffa#10 and is bumping to v2.7.1 in anthropics/buffa#18).

Why the fork

Upstream was archived 2026-03-23 while still declaring using: "node20". GitHub force-upgrades Node 20 actions to Node 24 on 2026-06-02. No upstream fix is coming.

What v2.7.1 fixes over upstream

  1. Node 24 runtime (action.yml: node20node24)
  2. False-failure bug: reRunLastWorkFlowIfRequired() ran on every pull_request_target event, making 4-5 GitHub API calls after the "All contributors have signed ✅" message. Something in that chain could cause the step to exit non-zero without an error annotation — red check despite a clean log. v2.7.1 skips that logic on pull_request_target (it's only meaningful for issue_comment events) and isolates rerun errors so they never poison the CLA verdict. Also shaves ~9s off every PR-push check.

Verification

pull_request_target runs from the base branch, so this PR's own CLA check still uses upstream v2.6.1. The fork is first exercised on the next PR after this merges.

Upstream contributor-assistant/github-action was archived 2026-03-23
still on Node 20 (deprecated 2026-06-02). This fork bumps the runtime
to Node 24 and fixes a false-failure where the check would go red
after logging 'All contributors have signed'.

The false-failure root cause: reRunLastWorkFlowIfRequired() ran on
every pull_request_target event, making 4-5 GitHub API calls that
could cause the step to exit non-zero without an error annotation.
v2.7.1 skips that logic on pull_request_target (it's only needed for
issue_comment) and isolates rerun errors so they never poison the
CLA verdict.
@iainmcgin iainmcgin requested a review from asacamano March 30, 2026 16:57
@iainmcgin iainmcgin marked this pull request as ready for review March 30, 2026 16:57
@iainmcgin iainmcgin enabled auto-merge (squash) March 30, 2026 16:57
@iainmcgin iainmcgin merged commit 5a56c62 into main Mar 30, 2026
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants