Conversation
The codebase uses let-chains (if let X && Y) which were stabilized in 1.88, so 1.88 is the actual minimum supported version. Declares rust-version on the workspace and propagates it to all member crates, plus a new msrv-check CI job that runs cargo check on the pinned toolchain to keep this honest going forward.
This was referenced Apr 3, 2026
rpb-ant
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43
The workspace had no declared MSRV. The codebase actually uses let-chains (`if let Some(x) = y && condition`) in 20+ places across the published crates, and let-chains were stabilized in Rust 1.88, so 1.88 is the real minimum.
Changes
Verification
Notes
I initially tried 1.85 (matching the buffa workspace), but it fails for two compounding reasons:
Bumping to 1.88 reflects what the code already requires rather than refactoring the let-chains away.