fix(retry): treat request-level errors as retryable#2543
Merged
tusharmath merged 2 commits intomainfrom Mar 12, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat request-level reqwest errors as retryable, fixing the
peer closed connection without sending TLS close_notifyerror from the ChatGPT codex endpoint.Context
Requests to
https://chatgpt.com/backend-api/codex/responseswere failing permanently with:This error surfaces as a
reqwest::Errorwithis_request() == true. The existing retry check only coveredis_timeout()andis_connect(), so these request-level transport failures were never retried.Changes
|| e.is_request()tois_req_transport_error— a one-line fixTesting
cargo insta test --accept -p forge_repoLinks