feat: support FORGE_FOLDER_PATH env var for base path#2724
Open
majiayu000 wants to merge 2 commits intoantinomyhq:mainfrom
Open
feat: support FORGE_FOLDER_PATH env var for base path#2724majiayu000 wants to merge 2 commits intoantinomyhq:mainfrom
majiayu000 wants to merge 2 commits intoantinomyhq:mainfrom
Conversation
Check FORGE_FOLDER_PATH env var in ConfigReader::base_path() before falling back to ~/forge. Deduplicate the base_path logic in env.rs by reusing ConfigReader::base_path(). Closes antinomyhq#2662 Signed-off-by: majiayu000 <1835304752@qq.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2662
base_pathwas hardcoded to~/forgein two places:ConfigReader::base_path()inforge_configand inline into_environment()inforge_infra. This meant there was no way to change where Forge stores its data without modifying source.Now
ConfigReader::base_path()checksFORGE_FOLDER_PATHenv var first and falls back to~/forgeif unset. The duplicated path logic inforge_infra/src/env.rsnow callsConfigReader::base_path()instead of computing it separately, so there's a single source of truth.Two tests added: one confirming the env var override works, one confirming the default path is still
~/forge.