fix: adjust doctor script severity levels#2734
Merged
tusharmath merged 2 commits intoantinomyhq:mainfrom Mar 29, 2026
Merged
Conversation
- oh-my-zsh missing: fail → warn (not required, only zsh itself is) - theme not set / wrong theme: fail → warn (non-critical) - nerd font disabled: fail → warn (cosmetic preference) - rename section header "ZSH Theme RPROMPT" → "FORGE RIGHT PROMPT" - add "forge zsh setup" as alternative plugin install instruction Closes antinomyhq#2612 Signed-off-by: majiayu000 <1835304752@qq.com>
Collaborator
|
@majiayu000 I have deleted the bounty for this issue. Let me know if you are ok with merging this PR. |
Contributor
Author
|
@tusharmath Plz merge if it slove the issue. |
tusharmath
added
the
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2612
print_result failwas used for optional features (oh-my-zsh, nerd fonts, forge theme) which madeforge doctorexit non-zero even when the core setup was fine. Changed these toprint_result warnso only actually-broken things (like missing zsh or forge binary) cause failures.Changes in
shell-plugin/doctor.zsh:forge zsh setupas alternative instruction when plugin isn't loaded (line 155)Exit-code-0-on-warnings-only was already implemented correctly, no change needed there.
Tested with
cargo buildandcargo test --all-features --workspace— both pass.