Add handling for ESC-b (backwards one word) and ESC-f (forwards one word... #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2014 06:16
words are series of alpha-numeric character. Use !isalnum() to find the separators.
linenoise.c
Outdated
There was a problem hiding this comment.
One minor issue I noticed is that trying to move to the beginning of a line starting with whitespace (or any other separators) stops after the first character (e.g. ..^a moves to .^.a, where ^ is the cursor). Adding an exemption here if the cursor position is 0 should fix this:
if (isWordSep(l->buf[l->pos]) && l->pos != 0) l->pos++;Other than that, I can't find any problems. 👍
lethosor found issue when there are separator chars at beginning of line. The code didn't allow the cursor at position 0. Fixed the while loop to break out when pos is at the first char of word. No need to fixing the position afterwards like the original loop. So the cursor can now go to pos 0 even when it contains a separator character.
Author
|
Fixed the problem of the edge case by modifying the loop that moves the cursor over a word. It stops at the first char of the word boundary. It does this by looking at the char to the left of the current line position, breaking out of the loop if that char is not a word separator. Added bonus, decrease line count by 2 :) |
Handle the delete-next word key sequence of Alt-d Map Alt-h, Alt-BACKSPACE to delete previous word.
Start implementation of help ('?' handling)
Add command handler to example
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding something I use all the time on cli.
First time with pull request, hope this works.
thanks
wing