Include stddef.h for size_t #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I just ran into this issue also (it wasn't difficult to figure out or fix, of course, but the point is still valid). |
|
Merged rain-1@1e4ea01 thank you |
francisbouvier
added a commit
to lightpanda-io/zig-js-runtime
that referenced
this pull request
Mar 10, 2023
antirez/linenoise does not seems maintened anymore. Especially this issue is blocking antirez/linenoise#65 Signed-off-by: Francis Bouvier <francis.bouvier@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers should compile as if they were source code too. Without including stddef.h, linenoise.h cannot be included without first including something that exposes size_t. stddef.h is the least invasive way of doing this, other headers like stdio.h and string.h; while they may expose size_t are more invasive. This patch also fixes trailing whitespace in the license header as well.