Skip to content

Conversation

@vtjnash
Copy link

@vtjnash vtjnash commented Aug 12, 2014

This fixes two issues:

  1. a call to write assumed little-endian, a cast to char is necessary to ensure the addressof operator points to the correct byte
  2. a cast from int to char assumes char is signed, this cast needs to be delayed until after the sign test

@rain-1
Copy link

rain-1 commented May 15, 2018

Merged rain-1@90ad99e

@vtjnash
Copy link
Author

vtjnash commented Mar 11, 2021

  1. was incidentally fixed
  2. is still an open issue

@OlliV
Copy link

OlliV commented Mar 15, 2021

I think the issue is not that you are running big-endian code but that char is unsigned by default on PowerPC (and ARM).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants