Fix: Country filter plain text #452

chaitanyya · 2025-07-08T22:48:05Z

Fixes #450

Loom: https://www.loom.com/share/f05b867d69924f2f895315462cf0d891

Summary by CodeRabbit

Tests
- Added end-to-end tests to verify that country selection fields in tax settings support searching by partial country names, case-insensitive input, and country codes.
Refactor
- Enhanced country selection options to include additional search keywords for improved searchability.

coderabbitai · 2025-07-08T22:48:12Z

Walkthrough

A new end-to-end test was added to verify that the country selection comboboxes on the tax settings page support case-insensitive and partial-name search. Additionally, the ComboBox component was updated to pass a keywords prop containing the option label to each CommandItem, likely to enhance search functionality.

Changes

File(s)	Change Summary
e2e/settings/tax.spec.ts	Added an end-to-end test verifying country combobox search supports partial and case-insensitive input.
frontend/components/ComboBox.tsx	Added `keywords` prop to `CommandItem` for each option, set to the option label.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TaxSettingsPage
    participant ComboBox
    participant CommandItem

    User->>TaxSettingsPage: Opens Tax Settings
    User->>ComboBox: Clicks country combobox
    User->>ComboBox: Types partial/case-insensitive country name
    ComboBox->>CommandItem: Passes keywords (option label)
    ComboBox-->>User: Displays filtered country options
    User->>ComboBox: Selects country
    ComboBox-->>TaxSettingsPage: Updates selected value

Assessment against linked issues

Objective	Addressed	Explanation
Fix combobox search inputs to support partial and case-insensitive country name search (#450)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Poem

In the garden of forms where the combobox grows,
A bunny hopped in and fixed search woes.
Now "Polan" or "CANADA" spring up with ease,
Bringing users delight and rabbits to tease.
With keywords in place, the search is a breeze!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5f8a6e and 388b754.

📒 Files selected for processing (2)

e2e/settings/tax.spec.ts (1 hunks)
frontend/components/ComboBox.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

`frontend/components/**/*.tsx`: Sentence case headers and buttons and stuff, not...

frontend/components/**/*.tsx: Sentence case headers and buttons and stuff, not title case
Add any components to frontend/components/**/*.tsx when adding a feature
Do not use React.FC. Use the following syntax: const Component = ({ prop1, prop2 }: { prop1: string; prop2: number }) => { ... } for front-end code

📄 Source: CodeRabbit Inference Engine (.cursorrules)

List of files the instruction was applied to:

frontend/components/ComboBox.tsx

`**/*.{ts,tsx,js,jsx,rb}`: Newlines at end of files, always Add a `TODO (techdeb...

**/*.{ts,tsx,js,jsx,rb}: Newlines at end of files, always
Add a TODO (techdebt) comment to document refactors that should be made in the future
UNDER ANY CIRCUMSTANCES, DO NOT ADD COMMENTS TO THE CODE

📄 Source: CodeRabbit Inference Engine (.cursorrules)

List of files the instruction was applied to:

frontend/components/ComboBox.tsx
e2e/settings/tax.spec.ts

`e2e/**/*.spec.ts`: Use Playwright tests in `e2e/**/*.spec.ts` for end-to-end tests

e2e/**/*.spec.ts: Use Playwright tests in e2e/**/*.spec.ts for end-to-end tests

📄 Source: CodeRabbit Inference Engine (.cursorrules)

List of files the instruction was applied to:

e2e/settings/tax.spec.ts

🧠 Learnings (3)

📓 Common learnings

Learnt from: CR
PR: antiwork/flexile#0
File: .cursorrules:0-0
Timestamp: 2025-06-30T18:53:33.910Z
Learning: Applies to e2e/tests/**/*.ts : Add or update e2e tests in `e2e/tests/` that cover the changed functionality for TypeScript/Next.js changes

frontend/components/ComboBox.tsx (2)

Learnt from: CR
PR: antiwork/flexile#0
File: .cursorrules:0-0
Timestamp: 2025-06-30T18:53:33.910Z
Learning: Applies to frontend/components/**/*.tsx : Add any components to `frontend/components/**/*.tsx` when adding a feature

Learnt from: CR
PR: antiwork/flexile#0
File: .cursorrules:0-0
Timestamp: 2025-06-30T18:53:33.910Z
Learning: Applies to frontend/components/**/*.tsx : Sentence case headers and buttons and stuff, not title case

e2e/settings/tax.spec.ts (2)

Learnt from: CR
PR: antiwork/flexile#0
File: .cursorrules:0-0
Timestamp: 2025-06-30T18:53:33.910Z
Learning: Applies to e2e/tests/**/*.ts : Add or update e2e tests in `e2e/tests/` that cover the changed functionality for TypeScript/Next.js changes

Learnt from: CR
PR: antiwork/flexile#0
File: .cursorrules:0-0
Timestamp: 2025-06-30T18:53:33.910Z
Learning: Applies to e2e/**/*.spec.ts : Use Playwright tests in `e2e/**/*.spec.ts` for end-to-end tests

🔇 Additional comments (2)

frontend/components/ComboBox.tsx (1)

53-53: Good enhancement to search functionality.

Adding the keywords prop with the option label will improve the search matching capability of the ComboBox component, making it easier to find options by partial text matches.

e2e/settings/tax.spec.ts (1)

151-183: Excellent test coverage for the country search functionality.

This test comprehensively validates the enhanced search functionality in the ComboBox component, covering partial matches, case-insensitive search, and country code searches. The test structure follows the existing patterns and uses proper Playwright assertions.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

This reverts commit f4dd6e0.

slavingia · 2025-07-09T16:31:03Z

Looks like this broke other tests, could you retry? Please copy shadcn's code to ensure it's standard.

chaitanyya · 2025-07-09T18:45:39Z

@slavingia fixed in - #485

workers.io fix

388b754

VladSez mentioned this pull request Jul 8, 2025

bug: combobox search inputs are not working as expected #450

Closed

slavingia merged commit f4dd6e0 into antiwork:main Jul 8, 2025
3 of 4 checks passed

slavingia added a commit that referenced this pull request Jul 9, 2025

Revert "Fix: Country filter plain text (#452)"

1a2c1d0

This reverts commit f4dd6e0.

slavingia added a commit that referenced this pull request Jul 9, 2025

Revert "Fix: Country filter plain text (#452)" (#482)

099bbed

This reverts commit f4dd6e0.

coderabbitai bot mentioned this pull request Jul 9, 2025

Revert "Fix: Country filter plain text (#452)" #482

Merged

chaitanyya mentioned this pull request Jul 9, 2025

fix: search with working tests #485

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Country filter plain text #452

Fix: Country filter plain text #452

Uh oh!

chaitanyya commented Jul 8, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 8, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

slavingia commented Jul 9, 2025

Uh oh!

chaitanyya commented Jul 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix: Country filter plain text #452

Fix: Country filter plain text #452

Uh oh!

Conversation

chaitanyya commented Jul 8, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

slavingia commented Jul 9, 2025

Uh oh!

chaitanyya commented Jul 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chaitanyya commented Jul 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)