Add autofix.yml GitHub Actions workflow#50
Merged
Conversation
- Follows patterns from gumboard and helper repos - Uses npm and Node 18 to match existing test workflow - Includes lint with --fix for automatic code formatting - Uses typecheck via npm run build - Configured for autofix.ci integration Co-Authored-By: Sahil Lavingia <sahil@gumroad.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Include GH_CLIENT_SECRET and other GitHub secrets for build step - Matches environment setup from test.yml workflow - Ensures typecheck step can complete successfully Co-Authored-By: Sahil Lavingia <sahil@gumroad.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add autofix.yml GitHub Actions workflow
Summary
Adds an autofix.ci workflow to automatically fix linting and formatting issues on pull requests, following the pattern established in other antiwork repos (helper, gumboard, etc.).
Key changes:
.github/workflows/autofix.ymlwith lint auto-fixing and typecheck steps--fixflag since jacquez doesn't use Prettiernpm run buildfor type checkingReview & Testing Checklist for Human
npm run buildbut doesn't include the GitHub App secrets that the existing test.yml requires. This will likely cause CI failures. Consider either adding the required env vars or using a different typecheck approach.ubicloud-standard-2is available and appropriate for this repo (copied from gumboard pattern)Diagram
%%{ init : { "theme" : "default" }}%% graph TD TestYML["/.github/workflows/test.yml<br/>(existing)"]:::context AutofixYML["/.github/workflows/autofix.yml<br/>(new workflow)"]:::major-edit PackageJSON["/package.json<br/>(npm scripts)"]:::context EslintConfig["/.eslintrc.json<br/>(lint config)"]:::context TestYML --> PackageJSON AutofixYML --> PackageJSON AutofixYML --> EslintConfig TestYML -.->|"requires env vars<br/>for build"| BuildSecrets[GitHub App Secrets]:::context AutofixYML -.->|"missing env vars!"| BuildSecrets subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
Link to Devin run: https://app.devin.ai/sessions/42bc81cd79f648b1aae8f6eb421aed89
Requested by: @slavingia