Skip to content

feat: social links#109

Merged
antoncoding merged 4 commits intomasterfrom
feat/socials
Jan 9, 2025
Merged

feat: social links#109
antoncoding merged 4 commits intomasterfrom
feat/socials

Conversation

@antoncoding
Copy link
Owner

@antoncoding antoncoding commented Jan 9, 2025

  • temporarily disable docs

Summary by CodeRabbit

Release Notes

  • New Features

    • Added a "More" dropdown menu in the Navbar with quick access to documentation, Discord, GitHub, and theme toggle
    • Enhanced account dropdown with ability to copy wallet address and view on explorer
  • Improvements

    • Simplified navigation link active state determination
    • Centralized external link management
  • Chores

    • Updated component implementations using new UI library components
    • Removed standalone theme toggle button

@vercel
Copy link
Contributor

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monarch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 6:05pm

@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2025

Warning

Rate limit exceeded

@antoncoding has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9d1c8a8 and 77e0c0f.

📒 Files selected for processing (2)
  • src/components/layout/header/Navbar.tsx (4 hunks)
  • src/utils/external.ts (1 hunks)
📝 Walkthrough

Walkthrough

The pull request introduces modifications to the project's navigation and styling components. Key changes include replacing the Radix UI dropdown with NextUI components in the AccountDropdown, adding a new "More" dropdown in the Navbar, and creating a centralized EXTERNAL_LINKS constant for project URLs. A minor CSS change involves removing the scrollbar-gutter property, which might impact layout stability.

Changes

File Change Summary
app/global.css Removed scrollbar-gutter: stable property
src/components/layout/header/AccountDropdown.tsx Migrated to NextUI dropdown, added address copy functionality
src/components/layout/header/Navbar.tsx Added "More" dropdown, simplified active link logic, consolidated theme toggle
src/utils/external.ts Introduced EXTERNAL_LINKS constant with project URLs

Sequence Diagram

sequenceDiagram
    participant User
    participant Navbar
    participant AccountDropdown
    participant Clipboard

    User->>Navbar: Click "More"
    Navbar-->>User: Open dropdown
    User->>AccountDropdown: Open account menu
    User->>AccountDropdown: Select "Copy Address"
    AccountDropdown->>Clipboard: Copy wallet address
    Clipboard-->>User: Address copied
Loading

Possibly related PRs

Poem

🌐 Dropdowns dance, links take flight
Navbar sings with newfound might
Scrollbars quiet, addresses bright
Code refactored, pure delight!
Web's canvas painted just right 🚀

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
src/utils/external.ts (1)

35-39: Move URLs to environment variables

Hardcoded URLs make changes harder. Consider:

 export const EXTERNAL_LINKS = {
-  docs: 'https://docs.morpho.org',
-  discord: 'https://discord.gg/Ur4dwN3aPS',
-  github: 'https://github.com/monarch-xyz',
+  docs: process.env.NEXT_PUBLIC_DOCS_URL,
+  discord: process.env.NEXT_PUBLIC_DISCORD_URL,
+  github: process.env.NEXT_PUBLIC_GITHUB_URL,
 } as const;
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cee2af3 and 9d1c8a8.

📒 Files selected for processing (4)
  • app/global.css (0 hunks)
  • src/components/layout/header/AccountDropdown.tsx (1 hunks)
  • src/components/layout/header/Navbar.tsx (4 hunks)
  • src/utils/external.ts (1 hunks)
💤 Files with no reviewable changes (1)
  • app/global.css
🔇 Additional comments (1)
src/components/layout/header/Navbar.tsx (1)

129-132: Docs link implementation conflicts with PR objective

PR aims to disable docs but uses a toast. Consider:

  1. Remove docs link entirely
  2. Use commented URL with a feature flag
  3. Add explanation in PR description

@antoncoding antoncoding merged commit 379e4f4 into master Jan 9, 2025
3 of 4 checks passed
@antoncoding antoncoding deleted the feat/socials branch January 9, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant