Skip to content

feat: allow supplying on market page#113

Merged
antoncoding merged 1 commit intomasterfrom
feat/supply-unwhitelisted
Feb 11, 2025
Merged

feat: allow supplying on market page#113
antoncoding merged 1 commit intomasterfrom
feat/supply-unwhitelisted

Conversation

@antoncoding
Copy link
Owner

@antoncoding antoncoding commented Feb 11, 2025

Summary by CodeRabbit

  • New Features

    • Introduced a dedicated modal for asset supply, accessible via a new "Supply" button integrated in the market view.
    • Enhanced market displays with updated information on whitelisting for improved insights.
  • Bug Fixes

    • Refined error messaging during asset supply operations for better clarity.

@vercel
Copy link
Contributor

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monarch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 1:52pm

@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes add a new supply modal to the MarketContent component by importing and managing a SupplyModal via a new state variable. Additionally, the UI now includes a "Supply" button alongside the existing market view button. Modifications also include the removal of a console error log in SetupPositions, an update to the supply error message's capitalization in SupplyModal, an extra console log in MarketsContext for debugging, and an added whitelisted field in the MarketFields GraphQL fragment.

Changes

File(s) Change Summary
app/market/[chainId]/[marketid]/content.tsx, app/positions/components/onboarding/SetupPositions.tsx, src/components/supplyModal.tsx Introduced supply modal functionality: Imported SupplyModal, added showSupplyModal state with a new "Supply" button, removed a console error log in SetupPositions, and updated the error message string in SupplyModal.
src/contexts/MarketsContext.tsx Added a console log statement in the MarketsProvider to output the current markets state for debugging.
src/graphql/queries.ts Added a new whitelisted field to the MarketFields fragment in GraphQL query definitions.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant MC as MarketContent
    participant SM as SupplyModal

    U->>MC: Click "Supply" button
    MC->>MC: Set showSupplyModal = true
    MC->>SM: Render SupplyModal (passes market data and close handler)
    SM->>MC: Invoke close handler when closing modal
    MC->>MC: Set showSupplyModal = false
Loading

Possibly related PRs

Poem

In the market’s code, a new modal appears,
A "Supply" button lights up without fears.
Logs and messages refined with care,
Debug lines whisper secrets rare.
Whitelisted fields join the data stream,
A neat supply flow born from a single dream.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a8ccbae and b8bcbe0.

📒 Files selected for processing (5)
  • app/market/[chainId]/[marketid]/content.tsx (3 hunks)
  • app/positions/components/onboarding/SetupPositions.tsx (0 hunks)
  • src/components/supplyModal.tsx (1 hunks)
  • src/contexts/MarketsContext.tsx (1 hunks)
  • src/graphql/queries.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@antoncoding antoncoding merged commit 175d924 into master Feb 11, 2025
3 of 4 checks passed
@antoncoding antoncoding deleted the feat/supply-unwhitelisted branch February 11, 2025 13:52
@coderabbitai coderabbitai bot mentioned this pull request Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant