Skip to content

Improve context menus, add folder delete, fix dev version string#50

Merged
antoninbas merged 1 commit intomainfrom
feat/context-menu-improvements
Apr 18, 2026
Merged

Improve context menus, add folder delete, fix dev version string#50
antoninbas merged 1 commit intomainfrom
feat/context-menu-improvements

Conversation

@antoninbas
Copy link
Copy Markdown
Owner

Summary

  • Context menus: Right-click behavior is now meaningful for all entry types:
    • Top-level folders (notes/, logs/): Open only
    • User-created folders: Open + Delete (recursive, with confirmation)
    • Note files: Open + Edit (opens directly in edit mode) + Delete
    • Log files: Open + Delete (no Edit)
  • Folder delete: New end-to-end deleteFolder capability (core/notes.ts → router → HTTP client → DELETE /api/notes/folder endpoint → frontend API helper)
  • Dev version string: scripts/build.js now runs git describe at build time so dev builds show 0.11.0-dev.3+gabc1234 instead of the misleading plain 0.11.0

Bug fixes included

  • Fixed Open action for folders in context menu (SolidJS signal was cleared before the path was read — now captured first)

Test plan

  • Right-click notes/ or logs/ top-level folder → only "Open" appears, clicking it navigates in
  • Right-click a user-created folder → "Open" and "Delete" appear; Delete removes folder and contents
  • Right-click a note → "Open", "Edit", "Delete" all appear; Edit opens the note in edit mode
  • Right-click a log → "Open" and "Delete" appear (no Edit)
  • Build and check About modal shows version like 0.11.0-dev.N+gXXXXXXX

🤖 Generated with Claude Code

Context menu changes:
- Top-level folders (notes/, logs/): show "Open" only
- User-created folders: show "Open" and "Delete"
- Note files: show "Open", "Edit" (opens in edit mode), and "Delete"
- Log files: show "Open" and "Delete" (no Edit)
- Fix Open action for folders (capture entry before clearing menu signal)

New folder delete capability added end-to-end:
- core/notes.ts: deleteFolder() using fs.rm recursive
- core/router.ts + core/client.ts: route deleteFolder through server or direct
- web/api/notes.ts: DELETE /api/notes/folder endpoint
- web/app/lib/api.ts: notes.deleteFolder() frontend helper

Version string fix:
- scripts/build.js now runs git describe at build time
- Dev builds show "0.11.0-dev.3+gabc1234" instead of plain "0.11.0"
- Release builds (exact tag) still show clean "0.11.0"

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@antoninbas antoninbas merged commit f9ae179 into main Apr 18, 2026
6 checks passed
@antoninbas antoninbas deleted the feat/context-menu-improvements branch April 18, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant