Skip to content

Conversation

@marlocorridor
Copy link
Contributor

for issue #188 and #218

for checking on authentication_ioc_binding when set to array of values.
use `sessionData` class attribute
@marlocorridor
Copy link
Contributor Author

marlocorridor commented Jan 10, 2017

I do not understand why this error occur

Argument 1 passed to PragmaRX\Tracker\Data\RepositoryManager::__construct() must be an instance of PragmaRX\Tracker\Data\GeoIP, instance of PragmaRX\Support\GeoIp\GeoIp given, called in *****\vendor\pragmarx\tracker\src\Vendor\Laravel\ServiceProvider.php on line 322

please help. :)

@fntneves
Copy link

fntneves commented Feb 2, 2017

@marlocorridor Please, go to file

src/Data/RepositoryManager.php

and add this to the top so it will get the correct type:

use PragmaRX\Support\GeoIp\GeoIp;

@marlocorridor
Copy link
Contributor Author

Thanks a lot @fntneves . :)

@KeitelDOG
Copy link

Why hasn't this branch been merged yet? I got the "Call to undefined method PragmaRX\Tracker\Tracker::getSessionData()" when migrating from Laravel 4.2 to 5.0 .
Please @antonioribeiro or other Admin could you add this fix? Cause I really need this error fixed before I update my Staging Server.

@fntneves
Copy link

@marlocorridor You're welcome! :D

Would you please also commit that fix, if it is not already available?

Copy link

@KeitelDOG KeitelDOG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job @marlocorridor . This change is very good and resolve the problem of : Illegal offset type in isset or empty and Undefined method Tracker::getSessionData() as suggested.
I just tested it directly by changing the codes in vendor library in files Tracker.php and ServiceProvider.php .

Accessor getSessionData() could be created to return the protected $sessionData attribute, but since it is an internal call, everything is perfect.

@antonioribeiro I definitely think that this change should be merged. I'm not a fan of package hacking, this leaves unstable results when updating packages.

@marlocorridor
Copy link
Contributor Author

@fntneves included on my new commit. :)

@KeitelDOG
Copy link

@fntneves Could you please merge changes. I'm gonna upgrade from Laravel 4.2 to 5.0 on my Staging Server on Friday. And may be to Production the same day or on Saturday.

@fntneves
Copy link

fntneves commented Apr 5, 2017

@KeitelDOG I am not an admin of this repository. I would like to merge changes, actually.

\cc @antonioribeiro

@KeitelDOG
Copy link

@fntneves sorry I didn't know. I was just about to connect to my Staging server to upgrade to Laravel 5.0, and I check if it was merged. So I have no choice to do some code hacking on the files till then. Thanks.

@antonioribeiro
Copy link
Owner

Sorry for the delay, merged.

@antonioribeiro antonioribeiro merged commit af633e6 into antonioribeiro:master Jun 20, 2017
fly0305 pushed a commit to fly0305/stat-tracker-laravel that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants