-
Notifications
You must be signed in to change notification settings - Fork 601
fix Illegal offset type in isset or empty and Undefined method Tracker::getSessionData()
#230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for checking on authentication_ioc_binding when set to array of values.
update registerUserCheckCallback
use `sessionData` class attribute
35ce06c to
7aa3200
Compare
|
I do not understand why this error occur
please help. :) |
|
@marlocorridor Please, go to file
and add this to the top so it will get the correct type: |
|
Thanks a lot @fntneves . :) |
|
Why hasn't this branch been merged yet? I got the "Call to undefined method PragmaRX\Tracker\Tracker::getSessionData()" when migrating from Laravel 4.2 to 5.0 . |
|
@marlocorridor You're welcome! :D Would you please also commit that fix, if it is not already available? |
KeitelDOG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Job @marlocorridor . This change is very good and resolve the problem of : Illegal offset type in isset or empty and Undefined method Tracker::getSessionData() as suggested.
I just tested it directly by changing the codes in vendor library in files Tracker.php and ServiceProvider.php .
Accessor getSessionData() could be created to return the protected $sessionData attribute, but since it is an internal call, everything is perfect.
@antonioribeiro I definitely think that this change should be merged. I'm not a fan of package hacking, this leaves unstable results when updating packages.
|
@fntneves included on my new commit. :) |
|
@fntneves Could you please merge changes. I'm gonna upgrade from Laravel 4.2 to 5.0 on my Staging Server on Friday. And may be to Production the same day or on Saturday. |
|
@KeitelDOG I am not an admin of this repository. I would like to merge changes, actually. \cc @antonioribeiro |
|
@fntneves sorry I didn't know. I was just about to connect to my Staging server to upgrade to Laravel 5.0, and I check if it was merged. So I have no choice to do some code hacking on the files till then. Thanks. |
|
Sorry for the delay, merged. |
for issue #188 and #218