docs: sync skill files and CLAUDE.md with current framework#245
Merged
Conversation
Audit the repo's Claude skill docs against the live codebase and correct drift accumulated since they were last touched. Framework API updates: - Event bus -> Wolverine: IMessageBus, DomainEvent base record, convention handlers (replaces removed IEventBus/IEventHandler). - Validation -> FluentValidation: injected IValidator<T>, ValidateAsync, ToValidationErrors(), Core.Exceptions.ValidationException. - Views/ -> Pages/: IViewEndpoint co-located with its .tsx component. - Module impl csproj Microsoft.NET.Sdk.Razor -> Microsoft.NET.Sdk.StaticWebAssets, with SimpleModule.Database referenced only when the module owns a DbContext. - IModule hooks (ConfigureFeatureFlags/Agents/RateLimits/Host, CheckHealthAsync), settings builder .Add(), full SettingType enum, sealed IModulePermissions. CLAUDE.md "Adding a New Module": - SimpleModule.<Name>[.Contracts|.Tests] project naming, StaticWebAssets SDK, Endpoints/Pages feature dirs, Wolverine IMessageBus in the Core description. Accuracy fixes from self-review: - Correct framework/ directory list (drop non-existent DevTools/Agents/AI/Rag). - Pages feature subfolder is optional; import paths must match file location to avoid silent client-side 404s. - CA1812 is suppressed per-directory (Endpoints/, Pages/*Endpoint.cs), not global. - Show the DbContext ProjectReference as conditional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Audits all repo Claude skill files (
minimal-api,new-module,simplemodule+ its references) andCLAUDE.mdagainst the current SimpleModule framework and fixes drift accumulated since they were last touched.Why
The skill docs still described removed/renamed APIs, so anyone — human or agent — following them would write code against APIs that no longer exist (e.g.
IEventBus, static validators,Views/,Microsoft.NET.Sdk.Razor).Changes
Framework API drift
IMessageBus,DomainEvent, convention-discovered handlers); removedIEventBus/IEventHandler.IValidator<T>,await ValidateAsync,ToValidationErrors(),Core.Exceptions.ValidationException).Views/→Pages/(IViewEndpointco-located with its.tsx).Microsoft.NET.Sdk.Razor→Microsoft.NET.Sdk.StaticWebAssets;SimpleModule.Databasereferenced only when the module owns aDbContext.IModulehooks (ConfigureFeatureFlags/Agents/RateLimits/Host,CheckHealthAsync), settings.Add(), fullSettingTypeenum,sealed … : IModulePermissions.CLAUDE.md
SimpleModule.<Name>[.Contracts|.Tests]naming,StaticWebAssetsSDK,Endpoints/+Pages/feature dirs, and WolverineIMessageBusin the Core description.Accuracy fixes (from an extra-high-effort
/code-reviewself-pass)framework/directory list (removed non-existentDevTools/Agents/AI.*/Rag.*).Pages/feature subfolder is optional — removes aPages/{Feature}/rule that contradicted the flatimport('./X')example and would 404 client-side.Endpoints/,Pages/*Endpoint.cs), not globally.ProjectReferenceshown as conditional/commented.Verification
Every API name, enum member, csproj SDK, and path was checked against real tracked source (
framework/SimpleModule.Core/**and tracked modulesAdmin/Email/Settings/Users). Docs-only change — no application code touched; all code fences balanced.