Skip to content

Add types to the deployment file. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DheerajGBhatt merged 25 commits into from
Feb 26, 2023
Merged

Add types to the deployment file. #56

DheerajGBhatt merged 25 commits into from
Feb 26, 2023

Conversation

@DheerajGBhatt
Copy link
Member

@DheerajGBhatt DheerajGBhatt commented Jan 5, 2023

Description

Add types to the deployment file.

Issue ticket number and link

ROV-49

Type of change

  • Bug fix (non-breaking change which fixes an issue)

New Packages

@DheerajGBhatt
fix: seperated generateSAM
569cbe9
@DheerajGBhatt
fix: seperated generateSAM and removed unwanted packages and files
227f291
@DheerajGBhatt
removed package-lock file
6d9de75
@DheerajGBhatt
proper naming convention for sam generate in index.js
224d738
@DheerajGBhatt
fix : added types for generateSAM,getAppdata fully and partially for …
e43d7e9 
…cliModuletoConfig functions
@DheerajGBhatt
fix : added types for cliModuletoConfig,createStack and createStackRe…
d40464b 
…sources functions
@DheerajGBhatt
fix : added return type to createStackResources function
3a02387
@DheerajGBhatt
fix : seperated addComponents and addModule , folder is restructured
a035f47
@DheerajGBhatt
fix : added types file for addModule
84a53dd
@DheerajGBhatt
fix : formatted using prettier
acf16e8
@DheerajGBhatt
fix : removed dulicate functions
38cf51a
@DheerajGBhatt
fix : added strict types to addComponent module
4ce4838
@DheerajGBhatt
fix : removed unwanted comments and renamed interface
f8463dd
@DheerajGBhatt
fix : added strict types to add module
fa4fd0f
@DheerajGBhatt
fix : added strict types to add module
2c017dd
@DheerajGBhatt
fix : added strict types to functions
4a1bb43
@DheerajGBhatt
fix : added strict types to utilities function
50aa055
@DheerajGBhatt
fix : added strict types to utilities
6131650
@DheerajGBhatt
fix : replaced map with forEach
2d2f8d4
@DheerajGBhatt
fix : added proper values for TconfigFile
b49b5cb
@DheerajGBhatt
fix : added types to logics and modules files
2a725b3
@DheerajGBhatt
fix : removed types from modules files
d0b6b53
@DheerajGBhatt
fix : added types to components file
b4c82b9
@DheerajGBhatt
fix : added types to module file
1c8e0ed
@DheerajGBhatt
fix : added types to deployment file
4499f5b
@linear
Copy link

linear bot commented Jan 5, 2023

ROV-49 Add types to the deployment file.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DheerajGBhatt DheerajGBhatt merged commit 4499f5b into main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hnprashanth hnprashanth Awaiting requested review from hnprashanth

@vishwasnavadak vishwasnavadak Awaiting requested review from vishwasnavadak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DheerajGBhatt