fix: fix incorrect bounds calculate when pass stroke and lineWidth to group#1847
Merged
fix: fix incorrect bounds calculate when pass stroke and lineWidth to group#1847
Conversation
Aarebecca
changed the title
hustcc
reviewed
Nov 23, 2024
| @@ -0,0 +1,53 @@ | |||
| import { Group, Path, Rect, runtime } from '@antv/g'; | |||
|
|
|||
| export async function group_with_stroke(context) { | |||
Contributor
Author
There was a problem hiding this comment.
Bug 测试用例我就按照具体的问题原因命名的
Aarebecca
added a commit
that referenced
this pull request
Nov 25, 2024
* fix: fixed the issue where RenderCache could not cache RenderPipeline (#1839) * chore: add changeset * fix: fix incorrect bounds calculate when pass stroke and lineWidth to group (#1847) * fix: fix incorrect bounds calculate when pass stroke and lineWidth to group * chore: commit changeset * test: fix test case * update test (#1846) * chore: fix test * chore: update vite version * chore: update test snapshots * chore: remove pnpm-lock.yaml * chore: update workflows --------- Co-authored-by: Aaron <yangtao.yangtao@antgroup.com> * chore: update workflows (#1849) * chore(release): bump version (#1845) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: RE <1609403959@qq.com> Co-authored-by: wang1212 <mrwang1212@126.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strokelineWidth等参数时，包围盒计算异常的问题。修复前（绿色为包围盒区域）：
修复后：
