docs: set default lang=zh in readme#2839

Merged

visiky merged 1 commit intomasterfrom

docs-default-lang-zh

Sep 9, 2021

Member

hustcc commented Sep 9, 2021

PR includes

fixed #0
add / modify test cases
documents, demos

Screenshot

Before	After
❌	✅


          docs: set default lang=zh in readme

9e1410c

pr-triage bot added the PR: unreviewed label

hustcc requested a review from visiky

September 9, 2021 03:17

accesslint bot suggested changes

View reviewed changes

accesslint bot left a comment

There are accessibility issues in these changes.

README.en-US.md Show resolved Hide resolved

README.md Show resolved Hide resolved

README.en-US.md Show resolved Hide resolved

README.md Show resolved Hide resolved

README.md

-              <img src="https://gw.alipayobjects.com/mdn/rms_d314dd/afts/img/A*rqI2Qqt0pTwAAAAAAAAAAABkARQnAQ" />
+              <div align="center">
+              <img src="https://gw.alipayobjects.com/mdn/rms_d314dd/afts/img/A*rqI2Qqt0pTwAAAAAAAAAAABkARQnAQ" width="600" />

accesslint bot Sep 9, 2021

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

README.en-US.md Show resolved Hide resolved

README.md

-              <img src="https://gw.alipayobjects.com/mdn/rms_d314dd/afts/img/A*37siRJftYDIAAAAAAAAAAABkARQnAQ" />
+              <div align="center">
+              <img src="https://gw.alipayobjects.com/mdn/rms_d314dd/afts/img/A*37siRJftYDIAAAAAAAAAAABkARQnAQ" width="450" />

accesslint bot Sep 9, 2021

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

README.en-US.md

-              <div align="center">
-              <img src="https://gw.alipayobjects.com/mdn/rms_d314dd/afts/img/A*37siRJftYDIAAAAAAAAAAABkARQnAQ" width="450" />
-              </div>
+              <img src="https://gw.alipayobjects.com/mdn/rms_d314dd/afts/img/A*37siRJftYDIAAAAAAAAAAABkARQnAQ" />

accesslint bot Sep 9, 2021

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

README.en-US.md

    
              ## 🔗 Links

              <img src="https://gw.alipayobjects.com/zos/antfincdn/1yMwFkBvyV/chartcube-logo-cube.svg" width="18"> [ChartCube](https://chartcube.alipay.com/) - 基于 G2Plot 的在线图表制作工具，交互简单，一键导出图表代码！

              <img src="https://gw.alipayobjects.com/zos/antfincdn/1yMwFkBvyV/chartcube-logo-cube.svg" width="18"> [ChartCube](https://chartcube.alipay.com/) - Online chart making tool based on G2Plot.

accesslint bot Sep 9, 2021

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

README.md

    
              ## 🔗 相关链接

              <img src="https://gw.alipayobjects.com/zos/antfincdn/1yMwFkBvyV/chartcube-logo-cube.svg" width="18"> [ChartCube](https://chartcube.alipay.com/) - Online chart making tool based on G2Plot.

              <img src="https://gw.alipayobjects.com/zos/antfincdn/1yMwFkBvyV/chartcube-logo-cube.svg" width="18"> [ChartCube](https://chartcube.alipay.com/) - 基于 G2Plot 的在线图表制作工具，交互简单，一键导出图表代码！

accesslint bot Sep 9, 2021

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

pr-triage bot added PR: reviewed-changes-requested and removed PR: unreviewed labels

visiky merged commit 6c2fea3 into master

visiky deleted the docs-default-lang-zh branch

September 9, 2021 03:20

pr-triage bot added PR: merged and removed PR: reviewed-changes-requested labels

Contributor

github-actions bot commented Sep 9, 2021 •

edited

Loading

🎊 PR Preview 9e1410c has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2839.surge.sh?type=diff&date=2021-09-09

🕐 Build time: 100.791s

_{🤖 By surge-preview}

coveralls commented Sep 9, 2021

Pull Request Test Coverage Report for Build 1215786082

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.623%

Totals
Change from base Build 1186255225:	0.0%
Covered Lines:	6520
Relevant Lines:	6640

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels