Skip to content

docs: 修正元素状态属性栏, 禁用状态名描述错误,将 disable 更正为 disabled#7334

Merged
louhaojie99 merged 1 commit intov5from
fix_state_disabled
Aug 15, 2025
Merged

docs: 修正元素状态属性栏, 禁用状态名描述错误,将 disable 更正为 disabled#7334
louhaojie99 merged 1 commit intov5from
fix_state_disabled

Conversation

@louhaojie99
Copy link
Copy Markdown
Member

修正的问题:

image image

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @louhaojie99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

这个PR旨在修正文档中的一个拼写错误。在描述元素状态的文档中,将“禁用状态”的英文名称从“disable”更正为正确的“disabled”,以提高文档的准确性。

Highlights

  • 文档修正: 将 packages/site/docs/manual/element/state.en.md 文件中关于元素禁用状态的描述从 disable 更正为 disabled。
  • 本地化文档同步: 相应地,在 packages/site/docs/manual/element/state.zh.md 文件中也进行了相同的修正,确保中英文文档的一致性。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 将文档中的内置状态名从 disable 更正为 disabled,这是一个很好的改进,使命名更加清晰和规范。审查中发现,相关的代码示例没有完全同步修改,为了避免用户困惑,建议一并更新。具体请看文件中的评论。

| `highlight` | Highlight state | Elements that need emphasis |
| `inactive` | Inactive state | Dimmed display of unfocused elements |
| `disable` | Disabled state | Non-interactive elements |
| `disabled` | Disabled state | Non-interactive elements |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

感谢将状态名修正为 disabled,这是一个很好的改进。

不过,为了保持文档的一致性,第 63 行的状态样式配置代码示例也应该同步更新。该示例目前仍在使用 disable

      disable: {
        fill: '#ECECEC',
        stroke: '#BFBFBF',
        opacity: 0.5,
      },

建议将其更改为 disabled,以便与表格和文档中的其他示例(如 162 行)保持一致。

Copy link
Copy Markdown
Member Author

@louhaojie99 louhaojie99 Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

的确这里也是错误的,我来修改一下。

不生效:
image

生效:
image

| `highlight` | 高亮状态 | 需要强调显示的元素 |
| `inactive` | 非活跃状态 | 淡化显示非关注元素 |
| `disable` | 禁用状态 | 不可交互的元素 |
| `disabled` | 禁用状态 | 不可交互的元素 |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

感谢将状态名修正为 disabled,这是一个很好的改进。

不过,为了保持文档的一致性,第 63 行的状态样式配置代码示例也应该同步更新。该示例目前仍在使用 disable

      disable: {
        fill: '#ECECEC',
        stroke: '#BFBFBF',
        opacity: 0.5,
      },

建议将其更改为 disabled,以便与表格和文档中的其他示例(如 162 行)保持一致。

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你真聪明,牛 👍🏻

image

@hustcc
Copy link
Copy Markdown
Member

hustcc commented Aug 14, 2025

这个是文档写错了是吧,代码中还是 disabled ?

@louhaojie99
Copy link
Copy Markdown
Member Author

这个文档写错了是吧,代码中还是禁用了?

是的,只是文档写错了,代码层面没有问题!

@louhaojie99 louhaojie99 merged commit 0a37c19 into v5 Aug 15, 2025
1 check passed
@louhaojie99 louhaojie99 deleted the fix_state_disabled branch August 15, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants