Skip to content

fix(exporter): ensure PNG/SVG export covers all foreignObject text #227

Merged
Aarebecca merged 7 commits into
antvis:mainfrom
rnb-tron:feature/png_exporter_fix
Mar 31, 2026
Merged

fix(exporter): ensure PNG/SVG export covers all foreignObject text #227
Aarebecca merged 7 commits into
antvis:mainfrom
rnb-tron:feature/png_exporter_fix

Conversation

@rnb-tron
Copy link
Copy Markdown
Contributor

fix #226

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the SVG export functionality to correctly handle text within foreignObject elements that may overflow due to flex alignment. It introduces a mechanism to compute and apply a new viewBox that encompasses all text content, ensuring complete and accurate rendering in exported PNG/SVG images.

Highlights

  • Foreign Object Text Coverage: Ensures that PNG/SVG export covers all foreignObject text, addressing issue [ Live Editor ]编辑器模块中,复制或下载的PNG中,部分文本展示不全 #226.
  • ViewBox Computation: Implements a computeFullViewBox function to calculate a viewBox that fully covers all foreignObject text content, accounting for overflow caused by flex alignment.
  • Dynamic ViewBox Adjustment: Dynamically adjusts the SVG's viewBox attribute during export to accommodate potentially overflowing text content within foreignObject elements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds functionality to correctly calculate the viewBox for SVG exports to include all text content within foreignObject elements, preventing it from being cut off. The approach is sound. I have a couple of suggestions to enhance the robustness and maintainability of the new code.

Comment thread src/exporter/svg.ts
Comment thread src/exporter/svg.ts Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 14.49275% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.54%. Comparing base (ea238f5) to head (ec12e6f).

Files with missing lines Patch % Lines
src/exporter/svg.ts 14.49% 59 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   46.62%   46.54%   -0.09%     
==========================================
  Files         342      342              
  Lines       28261    28329      +68     
  Branches     2368     2374       +6     
==========================================
+ Hits        13177    13186       +9     
- Misses      15072    15131      +59     
  Partials       12       12              
Flag Coverage Δ
infographic 46.54% <14.49%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/exporter/svg.ts 64.97% <14.49%> (-11.50%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aarebecca
Copy link
Copy Markdown
Contributor

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements automatic viewBox expansion for SVG exports to ensure that content within foreignObject elements is not clipped, particularly when using flexbox alignments like center or flex-end. It also refactors the Infographic component to expose a download method via useImperativeHandle and adds download buttons to the development preview. Feedback focuses on improving the robustness of the overflow detection by using getComputedStyle for alignment, supporting horizontal overflow, and targeting generic child elements within foreignObject instead of specific tags.

Comment thread src/exporter/svg.ts Outdated
Comment thread src/exporter/svg.ts
Comment thread src/exporter/svg.ts Outdated
@Aarebecca
Copy link
Copy Markdown
Contributor

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements automatic viewBox expansion for SVG exports to capture content overflowing from foreignObject elements, specifically handling various flexbox alignments. It also refactors the Infographic component to expose a download method via a ref and adds export buttons to the development preview. Feedback recommends extending the alignment checks to include modern CSS values like 'end' and 'right' for more robust overflow calculation.

Comment thread src/exporter/svg.ts Outdated
Comment thread src/exporter/svg.ts Outdated
@Aarebecca Aarebecca merged commit 59a231f into antvis:main Mar 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ Live Editor ]编辑器模块中,复制或下载的PNG中,部分文本展示不全

3 participants