fix(exporter): ensure PNG/SVG export covers all foreignObject text #227
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the SVG export functionality to correctly handle text within foreignObject elements that may overflow due to flex alignment. It introduces a mechanism to compute and apply a new viewBox that encompasses all text content, ensuring complete and accurate rendering in exported PNG/SVG images. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds functionality to correctly calculate the viewBox for SVG exports to include all text content within foreignObject elements, preventing it from being cut off. The approach is sound. I have a couple of suggestions to enhance the robustness and maintainability of the new code.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 46.62% 46.54% -0.09%
==========================================
Files 342 342
Lines 28261 28329 +68
Branches 2368 2374 +6
==========================================
+ Hits 13177 13186 +9
- Misses 15072 15131 +59
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements automatic viewBox expansion for SVG exports to ensure that content within foreignObject elements is not clipped, particularly when using flexbox alignments like center or flex-end. It also refactors the Infographic component to expose a download method via useImperativeHandle and adds download buttons to the development preview. Feedback focuses on improving the robustness of the overflow detection by using getComputedStyle for alignment, supporting horizontal overflow, and targeting generic child elements within foreignObject instead of specific tags.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements automatic viewBox expansion for SVG exports to capture content overflowing from foreignObject elements, specifically handling various flexbox alignments. It also refactors the Infographic component to expose a download method via a ref and adds export buttons to the development preview. Feedback recommends extending the alignment checks to include modern CSS values like 'end' and 'right' for more robust overflow calculation.
fix #226