Skip to content

Conversation

@xunge0613
Copy link
Contributor

Update README-adjustTotalNodesCoordinate.md ,文档勘误

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

文档勘误,README-adjustTotalNodesCoordinate.md

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Update README-adjustTotalNodesCoordinate.md ,文档勘误
@github-actions
Copy link
Contributor

你好 @xunge0613,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @xunge0613, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

@github-actions github-actions bot added the pr(documentation) documentation label Mar 27, 2025
@github-actions github-actions bot requested a review from Alexzjt March 27, 2025 14:42
@petercat-assistant
Copy link

概述

此 PR 对 README-adjustTotalNodesCoordinate.md 文档进行了勘误和更新,主要涉及术语的更正和逻辑描述的调整,以提高文档的准确性和可读性。

变更

文件名 概要
README-adjustTotalNodesCoordinate.md 修正了术语(如 totalDimensionGroup 改为 grandTotalsGroupDimensions),并调整了逻辑描述以更准确地反映代码逻辑。

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Mar 27, 2025
@Alexzjt
Copy link
Contributor

Alexzjt commented Mar 29, 2025

@xunge0613 感谢你的贡献!

@Alexzjt
Copy link
Contributor

Alexzjt commented Mar 29, 2025

@xunge0613 Lint没过
packages/s2-core/src/facet/README-adjustTotalNodesCoordinate.md:55:33 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

fix markdown lint
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.78%. Comparing base (ecdc9c8) to head (90d6de2).
Report is 652 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3133      +/-   ##
==========================================
+ Coverage   75.77%   75.78%   +0.01%     
==========================================
  Files         257       19     -238     
  Lines       11994      665   -11329     
  Branches     2464      116    -2348     
==========================================
- Hits         9088      504    -8584     
+ Misses       1398       92    -1306     
+ Partials     1508       69    -1439     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alexzjt Alexzjt merged commit bf28c97 into antvis:next Mar 31, 2025
9 checks passed
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next 2.0-next 版本的问题 pr(documentation) documentation released on @latest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants