5.0 release

[newhouse]

5.0.0 that updates Pydantic and other dependencies, while addressing some breaking changes.

[newhouse]

@cyrusradfar and @rgimen3z

Would you mind pulling down and trying out 5.0.0b1 to make sure that things are working as expected for you? I'd feel much better if you two were able to make sure that this was working well for you before I released it.

Thanks!!!

[cyrusradfar]

Sure, I’ll try to test before Monday and will follow up with feedback.

…

On Fri, Dec 20, 2024 at 5:01 PM Chris Newhouse ***@***.***> wrote: @cyrusradfar <https://github.com/cyrusradfar> and @rgimen3z <https://github.com/rgimen3z> Would you mind pulling down and trying out 5.0.0b1 to make sure that things are working as expected for you? I'd feel much better if you two were able to make sure that this was working well for you before I released it. Thanks!!! — Reply to this email directly, view it on GitHub <#68 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABASCWD3VVVN4DUBKKBD2NL2GS4WTAVCNFSM6AAAAABT7YKKVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJXHEZDQMZRHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- This message is intended only for the individual or entity to which it is addressed.  It may contain privileged, confidential information which is exempt from disclosure under applicable laws.  If you are not the intended recipient, you are strictly prohibited from disseminating or distributing this information (other than to the intended recipient) or copying this information.  If you have received this communication in error, please notify us immediately by e-mail or by telephone at the above number. Thank you.

[rgimen3z]

thanks for working on this!

[rgimen3z]

could we unpin this? we have a couple dependencies that require urllib3>=2 that we'd have to downgrade. I believe I was able to remove the dependency in #65 and things still worked fine, but I don't have all the context

[rgimen3z]

i noticed this too, I think these aliases are just for serialization, and updating to serialization_alias makes mypy happy (also see: https://github.com/anvilco/python-anvil/pull/65/files)

[cyrusradfar]

@newhouse after reviewing and testing, it looked good. I saw a opportunity to clean up what I added and re-tested. Placed that here.

Otherwise, I'm good to go and would agree that the less we can pin on specific versions the better but that's non-blocking feedback.

Thanks for following up and taking this to the finish line.

[cyrusradfar]

👍 Approval

This is a solid update that modernizes the codebase and improves developer experience.

Key improvements I'm seeing:

• Upgrades Python version support (dropping 3.7, adding 3.11)
• Updates to Pydantic v2 syntax and best practices (yay!)
• Adds helpful example code and documentation
• Improves file handling with new FileCompatibleBaseModel
• Adds comprehensive tests for file handling

💡 Non-blocking Suggestions

1. Documentation

   • Consider adding a CHANGELOG.md entry for this significant version bump, last is from July
   • The new CLI example is great - maybe add it to the README.md highlights as well

2. Code Improvements

   • The commented out json_deserialize code in http.py could be removed
   • Consider adding type hints for the new file handling methods in models.py

3. Testing

   • The new file handling tests are thorough, but we could add a few edge cases:
     • Empty files
     • Very large files
     • Files with special characters in names

Overall

Lovely work modernizing the codebase while maintaining backward compatibility. The improved file handling and examples will make integration much easier for developers.

There's always more to do -- ready to merge! 🚀

[newhouse]

@rgimenez and @cyrusradfar

I have removed the pegging of urllib3 and re-published at 5.0.0b2 if you'd like to try it. Though I may just merge and publish this today.

[newhouse]

@rgimenez and @cyrusradfar

I have removed the pegging of urllib3 and re-published at 5.0.0b2 if you'd like to try it. Though I may just merge and publish this today.

[newhouse]

@rgimenez and @cyrusradfar

I have removed the pegging of urllib3 and re-published at 5.0.0b2 if you'd like to try it. Though I may just merge and publish this today.

[cyrusradfar]

@rgimenez and @cyrusradfar

I have removed the pegging of urllib3 and re-published at 5.0.0b2 if you'd like to try it. Though I may just merge and publish this today.

pulled and tested locally with no new issues. Thanks for adding the changelog

[newhouse]

@rgimen3z Im gonna merge this and it has been published as 5.0.0 but it doesn't support Python 3.12 as I couldn't get it to pass the CI tests. Maybe your PR can be revisited to fix that in another version.