-
Notifications
You must be signed in to change notification settings - Fork 139
Add template support for Mailgun #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
medmunds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is great. Appreciate the test and the updated docs.
I think there's just a minor change needed to get the tests to run.
Mailgun has two different template mechanisms and two different ways of providing substitution variables to them. Update Anymail's normalized merge_data handling to work with either (while preserving existing batch send and metadata capabilities that also use Mailgun's custom data and recipient variables parameters). Completes work started by @anstosa in #156. Closes #155.
Mailgun has two different template mechanisms and two different ways of providing substitution variables to them. Update Anymail's normalized merge_data handling to work with either (while preserving existing batch send and metadata capabilities that also use Mailgun's custom data and recipient variables parameters). Completes work started by @anstosa in #156. Closes #155.
Mailgun has two different template mechanisms and two different ways of providing substitution variables to them. Update Anymail's normalized merge_data handling to work with either (while preserving existing batch send and metadata capabilities that also use Mailgun's custom data and recipient variables parameters). Completes work started by @anstosa in #156. Closes #155.
|
Is there a planned time at which this will be available via pip? Right now I am only able to see 6.1 which doesn't support mailgun templates. |
|
@ryanovas this will appear in Anymail v7.0, which I'm hoping to have time to finish up and release over the weekend or early next week. Sorry for the delay; it took some research to figure out how to make Mailgun's new templates work with Anymail's merge data without breaking the other Mailgun template format or metadata. If you're in a rush, see this comment in the original issue for instructions on using Mailgun's new templates with older versions of Anymail. (Anymail has an |
|
Released in Anymail v7.0 |
Fixes #155