Skip to content

Conversation

@anstosa
Copy link
Contributor

@anstosa anstosa commented Jul 29, 2019

Fixes #155

@anstosa anstosa mentioned this pull request Jul 29, 2019
Copy link
Contributor

@medmunds medmunds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is great. Appreciate the test and the updated docs.

I think there's just a minor change needed to get the tests to run.

@medmunds medmunds merged commit 73a73ea into anymail:master Jul 30, 2019
medmunds added a commit that referenced this pull request Aug 30, 2019
Mailgun has two different template mechanisms and two different ways
of providing substitution variables to them. Update Anymail's
normalized merge_data handling to work with either (while preserving
existing batch send and metadata capabilities that also use Mailgun's
custom data and recipient variables parameters).

Completes work started by @anstosa in #156.
Closes #155.
medmunds added a commit that referenced this pull request Sep 3, 2019
Mailgun has two different template mechanisms and two different ways
of providing substitution variables to them. Update Anymail's
normalized merge_data handling to work with either (while preserving
existing batch send and metadata capabilities that also use Mailgun's
custom data and recipient variables parameters).

Completes work started by @anstosa in #156.
Closes #155.
medmunds added a commit that referenced this pull request Sep 3, 2019
Mailgun has two different template mechanisms and two different ways
of providing substitution variables to them. Update Anymail's
normalized merge_data handling to work with either (while preserving
existing batch send and metadata capabilities that also use Mailgun's
custom data and recipient variables parameters).

Completes work started by @anstosa in #156.
Closes #155.
@ryanovas
Copy link

ryanovas commented Sep 5, 2019

Is there a planned time at which this will be available via pip? Right now I am only able to see 6.1 which doesn't support mailgun templates.

@medmunds
Copy link
Contributor

medmunds commented Sep 6, 2019

@ryanovas this will appear in Anymail v7.0, which I'm hoping to have time to finish up and release over the weekend or early next week. Sorry for the delay; it took some research to figure out how to make Mailgun's new templates work with Anymail's merge data without breaking the other Mailgun template format or metadata.

If you're in a rush, see this comment in the original issue for instructions on using Mailgun's new templates with older versions of Anymail. (Anymail has an esp_extra override specifically so people don't have to wait on an Anymail update to use newly-released ESP features.)

@medmunds
Copy link
Contributor

medmunds commented Sep 7, 2019

Released in Anymail v7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mailgun Template Support

3 participants