chore: npm audit cleanup#12
Merged
Merged
Conversation
Resolve all critical/high advisories that have a clean forward fix,
avoiding npm's --force suggestions (which were major downgrades:
ethers 6->5, jest 29->25, nestjs 11->7).
- npm audit fix for in-range transitive bumps
- update @nestjs/* forward within v11
- bump jest->30, ts-jest->29, @types/jest->30 (dev only)
- overrides:
- multer ^2.2.0 (root of the nestjs high cluster; platform-express
pins the vulnerable 2.1.1)
- ws via $ws (ethers internally pins vulnerable 8.17.1; direct ws
range raised to ^8.21.0)
- js-yaml ^4.2.0 (clears the jest moderate cluster; the only 3.x copy
is under @istanbuljs/load-nyc-config, which only calls .load())
Remaining 10 are knowingly left (no clean forward fix): undici and the
warp-arbundles/warp-isomorphic/aoconnect chain, consul->uuid (uuid 11 is
ESM-only), geoip-lite->ip-address, secp256k1->elliptic.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jim-toth
changed the title
There was a problem hiding this comment.
Pull request overview
Updates npm dependency graph to address npm audit findings with forward-only upgrades (no major downgrades), using overrides to patch vulnerable transitive pins while keeping the project on the current NestJS major.
Changes:
- Add npm
overridesformulter,ws(via$ws), andjs-yamlto remediate transitive vulnerabilities. - Bump
wsdirect dependency to^8.21.0. - Upgrade test tooling:
jestto^30.4.2,ts-jestto^29.4.11, and@types/jestto^30.0.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve all critical/high advisories that have a clean forward fix, avoiding npm's --force suggestions (which were major downgrades: ethers 6->5, jest 29->25, nestjs 11->7).
Remaining 10 are knowingly left (no clean forward fix): undici and the warp-arbundles/warp-isomorphic/aoconnect chain, consul->uuid (uuid 11 is ESM-only), geoip-lite->ip-address, secp256k1->elliptic.