IOS-5255 Update Object Settings Menu #4181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
...er/TextEditor/EditorPage/Views/Settings/ObjectSettingsMenu/ObjectSettingsMenuViewModel.swift
Outdated
Show resolved
Hide resolved
...rces/PresentationLayer/TextEditor/EditorPage/Views/Settings/ObjectActions/ObjectAction.swift
Show resolved
Hide resolved
Contributor
Review SummaryThis PR implements a new object settings menu design with a unified interface, properly gated behind the Issues FoundObjectSettingsMenuViewModel.swift:108
ObjectAction.swift (new menuOrder property)
|
Co-authored-by: Vova Ignatov <ignatovv@users.noreply.github.com>
ignatovv
deleted the
ios-5255-update-object-settings-menu-converted-to-project
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
newObjectSettingsto toggle between old and new UI