IOS-5255 Migrate object settings menu to Observation framework #4188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced Combine publishers with withObservationTracking for manual observation of nested @observable objects. Changes include: - Removed Combine dependency and cancellables - Updated @StateObject to @State in views - Converted @published properties to regular properties - Added @ObservationIgnored to injected dependencies and non-observed properties - Implemented manual observation pattern using withObservationTracking for settings and actions
Contributor
Best PracticesObjectActionsViewModel.swift:2 - Unused import: ObjectSettingsViewModel.swift:2 - Unused import: |
ignatovv
force-pushed
the
ios-5255-update-object-settings-menu-converted-to-project-2
branch
from
c1a4d4a to
c0a4308
Compare
mgolovko
approved these changes
Oct 30, 2025
ignatovv
deleted the
ios-5255-update-object-settings-menu-converted-to-project-2
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@Publishedproperties with manual observation usingwithObservationTracking@Stateinstead of@StateObject@ObservationIgnoredto injected dependencies and non-observed propertiesThis completes the migration to modern Swift concurrency patterns for the object settings menu system.