Closed
Conversation
3acef33 to
12dfbb8
Compare
Contributor
|
I think I can't approve this unfortunately as this was a design decision, but I will ask. |
Design decision? Can you elaborate a little? |
Contributor
|
The main problem with changing width animation to translate is that right now there is common code that controls the resize of the sidebar, page resize and elements animation, splitting this code into show/hide and resize may be done but it will complicate things much more and we do not have time at the moment for this change. Maybe it will be reviewed one more time with the introduction of the right panel. By design decision I meant that we have discussed it with designers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using
translateto replace the originalleftandwidthanimations reduces the performance cost of page reflows.The modified code should allow for the removal of some width-related sections, but I'm not certain which ones are essential.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Spaces & widgets
vault.mov
Only widgets
default.mov
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?