preserve engine arguments when loading tables#14
Merged
Conversation
system.tables.engine returns only the bare engine name; arguments like the version column on ReplacingMergeTree(xo_received_at) live in engine_full. The diff path was dropping them, so emitted CREATE TABLE statements lost the deduplication semantics. Parse engine args from engine_full, store them on Table.EngineArgs, and emit them in the rebuilt DDL. An args change also triggers drop+recreate, mirroring how engine and ORDER BY changes are handled. Strips the leading replication parameters from Shared*/Replicated* engines to mirror NormalizeEngine's "Shared" prefix removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
system.tables.engine returns only the bare engine name; arguments like the version column on ReplacingMergeTree(xo_received_at) live in engine_full. The diff path was dropping them, so emitted CREATE TABLE statements lost the deduplication semantics. Parse engine args from engine_full, store them on Table.EngineArgs, and emit them in the rebuilt DDL. An args change also triggers drop+recreate, mirroring how engine and ORDER BY changes are handled.
Strips the leading replication parameters from Shared*/Replicated* engines to mirror NormalizeEngine's "Shared" prefix removal.