⚡ Bolt: Optimize BackgroundCarousel ken-burns animation#79
⚡ Bolt: Optimize BackgroundCarousel ken-burns animation#79
Conversation
…Swiper classes 💡 What: Modified `styles/components/_background-carousel.scss` to scope the `.ken-burns` animation specifically to `.swiper-slide-active`, `.swiper-slide-prev`, and `.swiper-slide-duplicate-active` classes. 🎯 Why: The Ken Burns effect relies on CSS transforms (scale) that consume significant CPU/GPU resources over a 7-second duration. Previously, this animation was applied uniformly to all 15 slides in the `BackgroundCarousel`, meaning hidden slides were actively recalculating layouts and transitions needlessly. The React state tracking approach was rejected due to unnecessary re-renders. 📊 Impact: Considerably reduces rendering overhead and prevents off-screen animation layouts, yielding a smoother overall carousel without triggering React re-renders. 🔬 Measurement: Can be verified by inspecting DOM elements in dev tools; slides lacking `-active` or `-prev` classes will not compute the `kenBurns` animation. Playwright script visually verified the carousel still functions perfectly. Co-authored-by: anyulled <100741+anyulled@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical performance enhancement for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (46)
📒 Files selected for processing (103)
📝 WalkthroughWalkthroughOptimizes Ken Burns animations in a Swiper carousel by migrating from React state tracking to pure CSS animations scoped to active/transitioning slides via Swiper's native classes, reducing re-renders and JavaScript overhead. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes the Ken Burns animation in the BackgroundCarousel by scoping it to active slides using CSS, which is a great performance improvement. My review includes a minor suggestion to update the related documentation in .jules/bolt.md to fully reflect the implemented CSS selectors, ensuring consistency and clarity for future reference.
…Swiper classes 💡 What: Modified `styles/components/_background-carousel.scss` to scope the `.ken-burns` animation specifically to `.swiper-slide-active`, `.swiper-slide-prev`, and `.swiper-slide-duplicate-active` classes. Also removed `package-lock.json` changes to fix CI build issues. 🎯 Why: The Ken Burns effect relies on CSS transforms (scale) that consume significant CPU/GPU resources over a 7-second duration. Previously, this animation was applied uniformly to all 15 slides in the `BackgroundCarousel`, meaning hidden slides were actively recalculating layouts and transitions needlessly. Using pure CSS scoping prevents this without triggering React re-renders. 📊 Impact: Considerably reduces rendering overhead and prevents off-screen animation layouts, yielding a smoother overall carousel. 🔬 Measurement: Can be verified by inspecting DOM elements in dev tools; slides lacking `-active` or `-prev` classes will not compute the `kenBurns` animation. Playwright script visually verified the carousel still functions perfectly. Co-authored-by: anyulled <100741+anyulled@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
styles/components/_background-carousel.scss (1)
74-76: Consider adding.swiper-slide-nextfor smoother forward transitions.Depending on Swiper's transition effect and timing, the "next" slide may become partially visible before receiving the
swiper-slide-activeclass. If users notice a slight animation jump on forward navigation, adding the next slide selector could help.💡 Optional: Include next slide in animation scope
.swiper-slide-active .background-carousel__slide.ken-burns, .swiper-slide-prev .background-carousel__slide.ken-burns, +.swiper-slide-next .background-carousel__slide.ken-burns, .swiper-slide-duplicate-active .background-carousel__slide.ken-burns { animation: kenBurns 7000ms ease-out both; animation-delay: 0s; }Test the carousel by navigating forward manually and observe whether there's any visible "pop" as the animation starts on the incoming slide.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@styles/components/_background-carousel.scss` around lines 74 - 76, The selector group (.swiper-slide-active .background-carousel__slide.ken-burns, .swiper-slide-prev .background-carousel__slide.ken-burns, .swiper-slide-duplicate-active .background-carousel__slide.ken-burns) should also include the next-slide state to cover forward transitions; update that selector list to add .swiper-slide-next .background-carousel__slide.ken-burns so the incoming slide gets the ken-burns animation scope before it becomes active and avoid visible pops during forward navigation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@styles/components/_background-carousel.scss`:
- Around line 70-79: The new high-specificity selectors (.swiper-slide-active
.background-carousel__slide.ken-burns, .swiper-slide-prev
.background-carousel__slide.ken-burns, .swiper-slide-duplicate-active
.background-carousel__slide.ken-burns) are outranking the existing
prefers-reduced-motion rule; to fix, add a matching rule inside the `@media`
(prefers-reduced-motion: reduce) block that targets the exact same selector list
and forces the animation off (e.g., animation: none !important or
animation-name: none !important) so the reduced-motion preference takes
precedence for the kenBurns animation.
---
Nitpick comments:
In `@styles/components/_background-carousel.scss`:
- Around line 74-76: The selector group (.swiper-slide-active
.background-carousel__slide.ken-burns, .swiper-slide-prev
.background-carousel__slide.ken-burns, .swiper-slide-duplicate-active
.background-carousel__slide.ken-burns) should also include the next-slide state
to cover forward transitions; update that selector list to add
.swiper-slide-next .background-carousel__slide.ken-burns so the incoming slide
gets the ken-burns animation scope before it becomes active and avoid visible
pops during forward navigation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 03f97faa-2021-447b-9185-a17eb0007a11
📒 Files selected for processing (2)
.jules/bolt.mdstyles/components/_background-carousel.scss
| /* ⚡ Bolt: Scope expensive animation to active/transitioning slides only. | ||
| Prevents animation from running on hidden slides and ensures it starts | ||
| exactly when the slide becomes visible. By placing it at the root level, | ||
| we avoid SCSS parent-selector nesting bugs. */ | ||
| .swiper-slide-active .background-carousel__slide.ken-burns, | ||
| .swiper-slide-prev .background-carousel__slide.ken-burns, | ||
| .swiper-slide-duplicate-active .background-carousel__slide.ken-burns { | ||
| animation: kenBurns 7000ms ease-out both; | ||
| animation-delay: 0s; | ||
| } |
There was a problem hiding this comment.
Good optimization approach, but specificity issue will break prefers-reduced-motion.
The CSS-only scoping to Swiper's native classes is a solid performance improvement. However, there's a specificity conflict with the prefers-reduced-motion query at lines 106-109.
The new selectors (specificity 0,3,0) will override the reduced-motion rule (specificity 0,2,0), meaning users who prefer reduced motion will still see the animation.
♿ Proposed fix to ensure reduced-motion takes precedence
`@media` (prefers-reduced-motion: reduce) {
- .background-carousel__slide.ken-burns {
+ .swiper-slide-active .background-carousel__slide.ken-burns,
+ .swiper-slide-prev .background-carousel__slide.ken-burns,
+ .swiper-slide-duplicate-active .background-carousel__slide.ken-burns {
animation: none;
}
.background-carousel__gradient {
animation: none;
}
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@styles/components/_background-carousel.scss` around lines 70 - 79, The new
high-specificity selectors (.swiper-slide-active
.background-carousel__slide.ken-burns, .swiper-slide-prev
.background-carousel__slide.ken-burns, .swiper-slide-duplicate-active
.background-carousel__slide.ken-burns) are outranking the existing
prefers-reduced-motion rule; to fix, add a matching rule inside the `@media`
(prefers-reduced-motion: reduce) block that targets the exact same selector list
and forces the animation off (e.g., animation: none !important or
animation-name: none !important) so the reduced-motion preference takes
precedence for the kenBurns animation.
Co-authored-by: anyulled <100741+anyulled@users.noreply.github.com>
…ctor) 💡 What: 1. Removed `minimatch` and `ajv` overrides from `package.json`. 2. Updated `cypress/e2e/home/home-editions.cy.ts` to look for the correct DOM element `.hero8-header__event-line` instead of `h5`. 🎯 Why: The recent CI runs failed for two distinct reasons: 1. `npm run test` and `npm run lint` failed due to dependency resolution errors. Specifically, `minimatch` override caused `test-exclude` to crash, and `ajv` override broke `eslint-plugin-eslint-comments` (both issues were logged in repository memory as expected behavior when those packages are overridden). Removing these overrides allows the base Next.js environment tools to run successfully. 2. `cypress-run` failed across all home pages because it was looking for `h5` tags, which have since been changed to `div` tags with the `.hero8-header__event-line` class (also documented in project memory). 📊 Impact: Restores a passing "green" pipeline state for the CI check suite. 🔬 Measurement: Successfully verified `npm run test` and `npm run lint` run without errors locally. Co-authored-by: anyulled <100741+anyulled@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
💡 What: Restored branch from `origin/main` baseline and manually re-applied only the target optimization to `styles/components/_background-carousel.scss`. Moved the `kenBurns` animation logic out of the `&__slide` nested selector to explicitly reference the fully qualified path (`.swiper-slide-active .background-carousel__slide.ken-burns`). 🎯 Why: This corrects the previously identified CSS nesting bug where `&.ken-burns` evaluated incorrectly within the parent scope. This achieves the core goal of only animating visible/transitioning slides, preventing hidden slides from spinning up useless GPU recalculations, while keeping `package.json` unmodified. 📊 Impact: Prevents GPU overhead and off-screen animation lag from 15 active 7s Ken Burns transforms. 🔬 Measurement: Verify using developer tools; only slides with Swiper state classes receive the `kenBurns` animation. Co-authored-by: anyulled <100741+anyulled@users.noreply.github.com>
1 participant
💡 What: Modified
styles/components/_background-carousel.scssto scope the.ken-burnsanimation specifically to.swiper-slide-active,.swiper-slide-prev, and.swiper-slide-duplicate-activeclasses.🎯 Why: The Ken Burns effect relies on CSS transforms (scale) that consume significant CPU/GPU resources over a 7-second duration. Previously, this animation was applied uniformly to all 15 slides in the
BackgroundCarousel, meaning hidden slides were actively recalculating layouts and transitions needlessly. The React state tracking approach was rejected due to unnecessary re-renders.📊 Impact: Considerably reduces rendering overhead and prevents off-screen animation layouts, yielding a smoother overall carousel without triggering React re-renders.
🔬 Measurement: Can be verified by inspecting DOM elements in dev tools; slides lacking
-activeor-prevclasses will not compute thekenBurnsanimation. Playwright script visually verified the carousel still functions perfectly.PR created automatically by Jules for task 10958252368080311219 started by @anyulled
Summary by CodeRabbit