Skip to content

Feature/6643 add current meters endpoint to get latest data version#30

Merged
weited merged 7 commits intomainfrom
feature/6643-add-current-meters-endpoint-to-get-latest-data-version
Apr 16, 2025
Merged

Feature/6643 add current meters endpoint to get latest data version#30
weited merged 7 commits intomainfrom
feature/6643-add-current-meters-endpoint-to-get-latest-data-version

Conversation

@weited
Copy link
Copy Markdown
Collaborator

@weited weited commented Apr 14, 2025

Alway return the latest one, don't need to specify which version to get
For plot having 48, ITFTIN
image

For plot having 49, ITFTIS
image

@weited weited requested a review from Copilot April 14, 2025 01:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/main/java/au/org/aodn/oceancurrent/model/ImageMetadataEntry.java:13

  • The 'depth' field has been removed from ImageMetadataEntry while it is still referenced in tests, converters, and index mappings. Consider restoring the field or refactoring dependent code to ensure consistency.
    private String depth;

src/main/java/au/org/aodn/oceancurrent/util/converter/ImageMetadataConverter.java:204

  • [nitpick] The variable name 'FileMetadata' duplicates the class name; renaming it to 'fileMetadata' would improve clarity and adhere to Java naming conventions.
FileMetadata FileMetadata = new FileMetadata();

@weited weited requested a review from kahmencheang April 14, 2025 01:31
Comment thread src/main/java/au/org/aodn/oceancurrent/service/SearchService.java Outdated
Comment thread src/main/java/au/org/aodn/oceancurrent/util/converter/ImageMetadataConverter.java Outdated
@weited weited requested a review from kahmencheang April 15, 2025 03:25
@weited weited merged commit 9edb2fa into main Apr 16, 2025
1 check passed
@weited weited deleted the feature/6643-add-current-meters-endpoint-to-get-latest-data-version branch April 16, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants