feat: update S3 bucket name in configuration and add logging for buck…

[weited]

…et listing

[Copilot]

Pull Request Overview

This PR updates the default S3 bucket fallback in the application configuration and adds logging of existing S3 buckets on application startup.

• Added a default fallback value for AWS_S3_BUCKET_NAME in application.yaml
• Introduced a @PostConstruct method in AwsConfig to list and log S3 buckets at startup

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/main/resources/application.yaml	Default S3 bucket name fallback set to oceancurrent-testing
src/main/java/au/org/aodn/oceancurrent/configuration/aws/AwsConfig.java	Added runTestToListS3Buckets startup method for bucket listing

Comments suppressed due to low confidence (2)

src/main/java/au/org/aodn/oceancurrent/configuration/aws/AwsConfig.java:67

• [nitpick] The method name runTestToListS3Buckets is misleading since this code executes in production; consider renaming it to listS3BucketsOnStartup or clarifying its purpose.

private void runTestToListS3Buckets() {

src/main/resources/application.yaml:44

• [nitpick] The new default bucket name oceancurrent-testing should be documented in the project’s configuration guide or README so all developers understand the fallback behavior.

bucket-name: ${AWS_S3_BUCKET_NAME:oceancurrent-testing}

[Copilot]

Using @PostConstruct to run an S3 bucket listing at startup can introduce unnecessary network calls and slow application initialization in production; consider moving this into a dedicated health endpoint or enabling it only under a non-production profile.

Suggested change

	@PostConstruct
	private void runTestToListS3Buckets() {
	public void listS3BucketsForHealthCheck() {

[Copilot]

Instantiating a new S3Client instead of injecting the existing bean bypasses Spring’s lifecycle and configuration; inject the S3Client bean to leverage singleton scope and improve testability.

[Copilot]

Catching a generic Exception can mask unexpected errors; narrow this catch block to specific exception types or rethrow unhandled exceptions to ensure issues aren’t silently ignored.

Suggested change

	} catch (Exception e) {
	log.error("Unexpected error during S3 bucket listing:", e);
	} catch (RuntimeException e) {
	log.error("Unexpected runtime error during S3 bucket listing:", e);
	throw e; // Rethrow to avoid masking critical runtime exceptions
	} catch (Exception e) {
	log.error("Unexpected checked exception during S3 bucket listing:", e);
	throw new RuntimeException("Unhandled exception during S3 bucket listing", e); // Wrap and rethrow