Skip to content

Feature/7295 index seal ctd data image into elastic search#49

Merged
weited merged 3 commits intomainfrom
feature/7295-index-seal-ctd-data-image-into-elastic-search
Aug 18, 2025
Merged

Feature/7295 index seal ctd data image into elastic search#49
weited merged 3 commits intomainfrom
feature/7295-index-seal-ctd-data-image-into-elastic-search

Conversation

@weited
Copy link
Copy Markdown
Collaborator

@weited weited commented Aug 18, 2025

No description provided.

@weited weited requested a review from Copilot August 18, 2025 02:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for SealCTD data by introducing a new product group and its associated child products to the ocean current service. The implementation includes configuration updates and comprehensive test coverage for the new SealCTD functionality.

Key changes:

  • Adds SealCTD product group with 8 child products covering seal tracks, timeseries, and tag data
  • Updates configuration files to define product hierarchy and JSON paths
  • Extends test suites to verify SealCTD product behavior and API responses

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
products.yaml Defines the SealCTD product group structure with child products for tracks, timeseries, and tag data
json-paths-config.yaml Maps SealCTD product paths to corresponding JSON data files under AATAMS directory
ProductServiceTest.java Adds unit tests for depth/region requirements validation with SealCTD products
ProductControllerTest.java Extends integration tests to include SealCTD mock data and API endpoint validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread src/main/resources/config/products.yaml Outdated
type: "ProductGroup"
children:
- title: "SealCTD Seal Track"
- id: "sealCtd-sealTrack"
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is missing the 'title' field. The YAML structure shows a title on line 135 followed by an id on line 136, but they should be part of the same item. The structure should be - title: "SealCTD Seal Track" followed by id: "sealCtd-sealTrack" on the next line with proper indentation.

Suggested change
- id: "sealCtd-sealTrack"
id: "sealCtd-sealTrack"

Copilot uses AI. Check for mistakes.
@weited weited merged commit 0b10e8b into main Aug 18, 2025
1 check passed
@weited weited deleted the feature/7295-index-seal-ctd-data-image-into-elastic-search branch August 18, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants