Bugs/5953 bug bbox #100
Merged
Bugs/5953 bug bbox #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+36
to
+43
| if(maxx >= 0 && maxx <= 180) { | ||
| // Normal case | ||
| polygons.add((Polygon)createBoxPolygon(minx, maxx, miny, maxy)); | ||
| } | ||
| else { | ||
| polygons.add((Polygon)createBoxPolygon(minx, 180, miny, maxy)); | ||
| polygons.add((Polygon)createBoxPolygon(-180, maxx, miny, maxy)); | ||
| } |
Contributor
There was a problem hiding this comment.
so you call createBoxPolygon and cast the result to Polygon, can we make return type of createBoxPolygon to Polygon with validating valid polygon?
vietnguyengit
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where any input value from frontend will be handle correctly by the CQL BBOX by adjust it within [-180, 180], geo_bounding_box in elastic require bbox to work within this range