💄 update data downloading emails to new designs #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utas-amberbian
force-pushed
the
feature/6486-update-data-downloading-email-designs
branch
from
045d238 to
676c0b6
Compare
Collaborator
|
@utas-amberbian conflicted |
Contributor
Author
Thanks @utas-raymondng, it's solved. But still waiting for @HavierD to confirm the final data structure for the email. |
HavierD
requested changes
Oct 22, 2025
Contributor
HavierD
left a comment
HavierD
left a comment
There was a problem hiding this comment.
Hello the N of the bbox is wrong. It is always 0. It is helper to have test cases for the EmailUtils.java to ensure quality.
Contributor
|
please don't merge this branch as Nirali fixed the snapshot |
HavierD
deleted the
feature/6486-update-data-downloading-email-designs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.