fix: mooring product processing level attribute for level 2#156
Merged
fix: mooring product processing level attribute for level 2#156
Conversation
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 70.52% 70.52%
=======================================
Files 12 12
Lines 1133 1133
Branches 153 153
=======================================
Hits 799 799
Misses 317 317
Partials 17 17 Continue to review full report at Codecov.
|
mhidas
previously approved these changes
May 13, 2022
Contributor
mhidas
left a comment
There was a problem hiding this comment.
👍 Good catch, and thanks for the fix.
While we're at it, though, the same fix is also needed in the gridded product.
mhidas
approved these changes
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mhidas the
file_versionandfile_version_quality_controldescription in the hourly timeseries products did not match our documentationThe aggregated product showing
Level 1file version has the same description as shown in the table on page 25, so I assumedLevel 2should also show the corresponding text.Following this fix we may want to re-process the hourly timeseries