Skip to content

fix: mooring product processing level attribute for level 2#156

Merged
mhidas merged 2 commits intomasterfrom
moorings_products_processing_level_attribute
May 13, 2022
Merged

fix: mooring product processing level attribute for level 2#156
mhidas merged 2 commits intomasterfrom
moorings_products_processing_level_attribute

Conversation

@evacougnon
Copy link
Copy Markdown
Contributor

@mhidas the file_version and file_version_quality_control description in the hourly timeseries products did not match our documentation

The aggregated product showing Level 1 file version has the same description as shown in the table on page 25, so I assumed Level 2 should also show the corresponding text.

Following this fix we may want to re-process the hourly timeseries

@evacougnon evacougnon requested a review from mhidas May 11, 2022 00:39
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2022

Codecov Report

Merging #156 (04ee2dd) into master (34a3ffe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files          12       12           
  Lines        1133     1133           
  Branches      153      153           
=======================================
  Hits          799      799           
  Misses        317      317           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a3ffe...04ee2dd. Read the comment docs.

mhidas
mhidas previously approved these changes May 13, 2022
Copy link
Copy Markdown
Contributor

@mhidas mhidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch, and thanks for the fix.
While we're at it, though, the same fix is also needed in the gridded product.

@mhidas mhidas merged commit ab01d2a into master May 13, 2022
@mhidas mhidas deleted the moorings_products_processing_level_attribute branch May 13, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants