Skip to content

Fix time scrambing issue in velocity hourly product#158

Merged
leonardolaiolo merged 4 commits intomasterfrom
fix_velocity_time_scrambing
May 26, 2022
Merged

Fix time scrambing issue in velocity hourly product#158
leonardolaiolo merged 4 commits intomasterfrom
fix_velocity_time_scrambing

Conversation

@mhidas
Copy link
Copy Markdown
Contributor

@mhidas mhidas commented May 16, 2022

Fixes #157 and adds unittests for velocity hourly code.

@mhidas mhidas requested a review from leonardolaiolo May 16, 2022 07:32
@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2022

Codecov Report

Merging #158 (99c92fc) into master (238f3ce) will increase coverage by 13.85%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #158       +/-   ##
===========================================
+ Coverage   70.52%   84.37%   +13.85%     
===========================================
  Files          12       12               
  Lines        1133     1133               
  Branches      153      153               
===========================================
+ Hits          799      956      +157     
+ Misses        317      156      -161     
- Partials       17       21        +4     
Impacted Files Coverage Δ
.../timeseries_products/velocity_hourly_timeseries.py 94.01% <100.00%> (+94.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238f3ce...99c92fc. Read the comment docs.

@leonardolaiolo leonardolaiolo merged commit c4f31cb into master May 26, 2022
@leonardolaiolo leonardolaiolo deleted the fix_velocity_time_scrambing branch May 26, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

velocity hourly timeseries product inconsistent with deployment file

2 participants