Skip to content

Fix ValueError in velocity_hourly_timeseries #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leonardolaiolo merged 1 commit into from
Jun 1, 2022
Merged

Fix ValueError in velocity_hourly_timeseries #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aodntools/timeseries_products/velocity_hourly_timeseries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def append_resampled_values(nc_cell, ds, slice_start, binning_functions):
:param binning_functions: list of numpy function names for binning
:return: end index of the slice
"""
df_cell = nc_cell.squeeze().to_dataframe()
df_cell = nc_cell.to_dataframe().reset_index().set_index('TIME')
# shift the index forward 30min to centre the bins on the hour
df_cell.index = df_cell.index + pd.Timedelta(minutes=30)

Expand Down
Binary file added test_aodntools/timeseries_products/IMOS_ANMN-NRS_ADCP_LAT_LON_DIMS.nc
View file
Open in desktop
Binary file not shown.
Binary file added test_aodntools/timeseries_products/IMOS_ANMN-NRS_ADCP_SINGLE_TIMESTAMP.nc
View file
Open in desktop
Binary file not shown.
10 changes: 10 additions & 0 deletions test_aodntools/timeseries_products/test_velocity_hourly_timeseries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,16 @@ def test_all_rejected(self):
self.assertRaises(NoInputFilesError, velocity_hourly_aggregated, [BAD_FILE], 'NRSROT',
input_dir=TEST_ROOT, output_dir='/tmp')

def test_size1_dimensions(self):
input_files = [
'IMOS_ANMN-NRS_ADCP_LAT_LON_DIMS.nc',
'IMOS_ANMN-NRS_ADCP_SINGLE_TIMESTAMP.nc'
]
output_file, bad_files = velocity_hourly_aggregated(input_files, 'NRSROT',
input_dir=TEST_ROOT, output_dir='/tmp')

self.assertEqual(0, len(bad_files))


if __name__ == '__main__':
unittest.main()