Merged
Conversation
(caused by time_deployment_start/end being well outside the time span covered by the data)
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 84.86% 84.86%
=======================================
Files 12 12
Lines 1130 1130
Branches 156 156
=======================================
Hits 959 959
Misses 152 152
Partials 19 19
Continue to review full report at Codecov.
|
Contributor
Author
bpasquer
approved these changes
Jun 15, 2022
Contributor
Author
|
Thanks @bpasquer ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an error that occurs when the
time_deployment_start/endattributes in an input file represent a longer time span than what is actually covered by the data. Previously this could lead to the code trying to select and process an empty subset of the data.