Skip to content

Fix velocity hourly IndexError#165

Merged
bpasquer merged 1 commit intomasterfrom
velocity_hourly_indexerror
Jun 15, 2022
Merged

Fix velocity hourly IndexError#165
bpasquer merged 1 commit intomasterfrom
velocity_hourly_indexerror

Conversation

@mhidas
Copy link
Copy Markdown
Contributor

@mhidas mhidas commented Jun 15, 2022

This is an error that occurs when the time_deployment_start/end attributes in an input file represent a longer time span than what is actually covered by the data. Previously this could lead to the code trying to select and process an empty subset of the data.

(caused by time_deployment_start/end being well outside the time span covered by the data)
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 15, 2022

Codecov Report

Merging #165 (7ee2483) into master (35e0167) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   84.86%   84.86%           
=======================================
  Files          12       12           
  Lines        1130     1130           
  Branches      156      156           
=======================================
  Hits          959      959           
  Misses        152      152           
  Partials       19       19           
Impacted Files Coverage Δ
.../timeseries_products/velocity_hourly_timeseries.py 95.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e0167...7ee2483. Read the comment docs.

@mhidas mhidas requested review from bpasquer and lbesnard June 15, 2022 02:49
@mhidas
Copy link
Copy Markdown
Contributor Author

mhidas commented Jun 15, 2022

@bpasquer @lbesnard My usual reviewer Leo is away, but this is just a very quick fix that should be pretty easy to review based on my explanation above. Any chance one of you could do a quick review?

@bpasquer bpasquer merged commit b3a467a into master Jun 15, 2022
@bpasquer bpasquer deleted the velocity_hourly_indexerror branch June 15, 2022 02:55
@mhidas
Copy link
Copy Markdown
Contributor Author

mhidas commented Jun 15, 2022

Thanks @bpasquer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants