Fix functions that modify files_to_agg argument in place#172
Merged
alexgleith merged 1 commit intomasterfrom Aug 18, 2022
Merged
Fix functions that modify files_to_agg argument in place#172alexgleith merged 1 commit intomasterfrom
alexgleith merged 1 commit intomasterfrom
Conversation
and add a simple test assertion to confirm fix
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 84.88% 84.96% +0.07%
==========================================
Files 12 12
Lines 1131 1137 +6
Branches 156 156
==========================================
+ Hits 960 966 +6
Misses 152 152
Partials 19 19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alexgleith
approved these changes
Aug 18, 2022
Contributor
alexgleith
left a comment
alexgleith
left a comment
There was a problem hiding this comment.
That's a good idea!
Being explicit is nice :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and add a simple test assertion to confirm fix