Conversation
So the issue is that the temp file is still open in Spyder, meaning that shutils cannot move the file at the end of the main aggregator function. I edited line 214 to include 'fd' as output: _, temp_outfile = tempfile.mkstemp(suffix='.nc', dir=output_dir) to fd, temp_outfile = tempfile.mkstemp(suffix='.nc', dir=output_dir). I can then close the object adding the following code to line 355 prior to using 'shutil.move': os.close(fd) This now works without an error for both 'aggregated_timeseries.py' and 'velocity_aggregated_timeseries.py'.
Used the same code as aggregated products
Codecov ReportBase: 85.54% // Head: 85.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 85.54% 85.58% +0.03%
==========================================
Files 10 10
Lines 1128 1131 +3
Branches 156 153 -3
==========================================
+ Hits 965 968 +3
Misses 144 144
Partials 19 19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@mhidas happy for you to proceed with this one. I'll start a new branch for future pull requests .. |
|
@leonardolaiolo This is a quick & easy one to review. |
|
Done @mhidas - I'll leave it to you to merge then. |
3 participants
Thanks @mphemming for identifying and fixing this issue.
(commits cherry-picked from #176)