fix(tui): swap ⌨ host-band glyph for a state triangle (▸/▾)#209
Merged
Conversation
The host-terminal band header led with a keyboard emoji — the lone outlier against the dashboard's sparse glyph set (◆/●/○). Swap it for a directional triangle that doubles as an expand/collapse affordance: ▸ when collapsed (points right), ▾ when expanded (points down). Header text still contains "Host", so the band tests stay green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ENXLudmsVvUbqa2hh1NvwS
aoos
added a commit
that referenced
this pull request
Jul 3, 2026
…not the set-up-a-server question (#209) (#272) detectFirstRunContext() classified a machine purely on daemon-reachability + the DEJIMA_HOST env var. A teammate who ran `dejima join <invite>` has a saved ACTIVE connection profile but no DEJIMA_HOST and no local daemon — so when that remote was momentarily unreachable, the classifier fell through to firstRunFreshHost and asked them to "set up a server on this machine" instead of opening their dashboard. A live teammate hit exactly this. Fix: once the daemon is unreachable, consult resolveTarget() (which already resolves DEJIMA_HOST, the -p/--host flag, AND the saved active profile). If ANY target exists (source != "local"), the machine is a client whose host is down — route to firstRunClientUnreachable (troubleshoot → dashboard), never firstRunFreshHost/Generic. Also generalize the "can't reach host" message to name a profile/flag target, not only DEJIMA_HOST. Regression tests: joined profile + unreachable → firstRunClientUnreachable; and the negative guard (no target + unreachable → not a configured client) so the fix doesn't over-broaden. Claude-Session: https://claude.ai/code/session_01ENXLudmsVvUbqa2hh1NvwS Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host-terminal band header led with a keyboard emoji (
⌨) — the lone outlier against the dashboard's sparse glyph vocabulary (◆islands,●/○state dots). Replace it with a directional triangle that doubles as an expand/collapse affordance:▸points right when collapsed (closed),▾points down when expanded (open).Two lines in
renderBand(cmd/dejima/tui.go). No behavior change. Band tests assert the header contains"Host"(not the glyph), so they stay green;go test ./cmd/dejima/...andgo vetclean locally.🤖 Generated with Claude Code