Grace mode for unknown model

[eugenkleinschmidt]

Would it be reasonable to introduce a grace mode when the hardware model is unknown, allowing the system to silently ignore settings that exceed outer limits?

voltcraft/voltcraft/pps.py

Lines 91 to 99 in 1777dca

	try:
	self._model = PPS_MODELS[(self._vmax, self._imax)]
	except KeyError:
	self._serial.close()
	raise RuntimeError(
	"unknown Voltcraft PPS model with max V: {}, I: {}".format(
	self._vmax, self._imax
	)
	)

[ap--]

Hi @eugenkleinschmidt,

My initial hope with this was to encourage contributions whenever someone else detects a new model. All that's needed is adding a new line to this:

voltcraft/voltcraft/pps.py

Lines 14 to 27 in 1777dca

	PPS_MODELS = {
	(18.0, 10.0): "PPS11810", # not confirmed yet
	(36.2, 07.0): "PPS11360", # confirmed
	(60.0, 02.5): "PPS11603", # not confirmed yet
	(18.2, 22.0): "PPS13610", # confirmed by Yanuino 2021-12-29, ersekcs 2021-11-24
	(36.2, 12.0): "PPS16005", # confirmed
	(60.0, 05.0): "PPS11815", # not confirmed yet
	(18.2, 12.0): "PPS11810", # added MB 2019-01-10
	(32.2, 21.5): "DPPS3220", # added tykling 2019-03-26
	(32.2, 31.5): "DPPS3230", # added cdleonard 2023-09-13
	(60.5, 11.0): "DPPS6010",
	(16.2, 43.0): "DPPS1640", # added chillinglu 2024-03-13
	(16.2, 33.0): "DPPS1630",
	}

But what we could do is instead of raising a RuntimeError here, to raise a warning that explains what would need to be added via a PR, and set the model name to unknown.

voltcraft/voltcraft/pps.py

Lines 91 to 99 in 1777dca

	try:
	self._model = PPS_MODELS[(self._vmax, self._imax)]
	except KeyError:
	self._serial.close()
	raise RuntimeError(
	"unknown Voltcraft PPS model with max V: {}, I: {}".format(
	self._vmax, self._imax
	)
	)

And then continue and just fallback to 0.0 for min voltage.

voltcraft/voltcraft/pps.py

Lines 101 to 105 in 1777dca

	try:
	self._vmin = PPS_MIN_VOLTAGE[self._model]
	except KeyError:
	self._serial.close()
	raise RuntimeError(f"unknown minimum voltage for Voltcraft {self._model}")

Would you be interested in making these changes in a PR?

Thanks,
Andreas ☺️