improves validation in unquote()#104
Merged
keith-turner merged 9 commits intoapache:mainfrom Mar 10, 2026
Merged
Conversation
Merged
ctubbsii
requested changes
Mar 10, 2026
modules/core/src/test/java/org/apache/accumulo/access/tests/AccessEvaluatorTest.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/accumulo/access/impl/CharsWrapper.java
Outdated
Show resolved
Hide resolved
modules/core/src/test/java/org/apache/accumulo/access/tests/AccessEvaluatorTest.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/accumulo/access/impl/AccessExpressionImpl.java
Outdated
Show resolved
Hide resolved
| throw new IllegalArgumentException("Unbalanced quotes : " + term); | ||
| } | ||
|
|
||
| term = len == 2 ? "" : AccessEvaluatorImpl.unescape(term.subSequence(1, len - 1)); |
Member
There was a problem hiding this comment.
In testing this, I wanted to see how AccessEvaluatorImpl.unescape handles quoted strings. It correctly fails (by the time it reaches this method, the outer quotes should be removed, and there should be no unescaped quotes in the string), but the error message is wrong. It says there is an illegal character after a slash, when I didn't provide any slashes in the string, just two quotes.
Contributor
Author
There was a problem hiding this comment.
Fixed that error message and added a test for it in 15ddc4c
…essExpressionImpl.java Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
…cessEvaluatorTest.java Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
ctubbsii
approved these changes
Mar 10, 2026
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
This is good, but I'm still curious if we can improve the error messages, and maybe some other stuff in the unescape method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test that do not currently pass. Opened as a follow on to #102 (comment)