Replace method calls with original checks using constants #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the methods from ByteUtils and reverted the places where the methods were called back to their original logic, but retained the use of the ByteUtils static variables. This yielded no significant performance difference. I re-ran the benchmarks on main before #27 was merged, the HEAD of main, and this branch. I ran
mvn clean verifyon each branch and ran the benchmark using the command:Here are the results: