memoizes creating a parse tree#84
Merged
keith-turner merged 1 commit intoapache:mainfrom Feb 11, 2025
Merged
Conversation
This change offers a new parse() method on AccessExpression that creates
a parse tree if one does not exits. This change allows decoupling how
access expression are created (w/ or w/o an initial parse tree) from
using parse trees.
For example code the like the following that wanted to use a parse tree
to validate an access expression would have required the
ParsedAccessExpression type to be passed to it. Now it can accept an
AccessExpression and call parse() which will do the most efficient thing
depending on how the expression was created.
```java
void checkExpression(AccessExpression expression){
var parsed = expression.parse();
// use parse tree to validate expression
}
```
ddanielr
approved these changes
Feb 11, 2025
Contributor
ddanielr
left a comment
ddanielr
left a comment
There was a problem hiding this comment.
Makes sense and I think allowing the users to not have to chose between object types is a great improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change offers a new parse() method on AccessExpression that creates a parse tree if one does not exits. This change allows decoupling how access expression are created (w/ or w/o an initial parse tree) from using parse trees.
For example code the like the following that wanted to use a parse tree to validate an access expression would have required the ParsedAccessExpression type to be passed to it. Now it can accept an AccessExpression and call parse() which will do the most efficient thing depending on how the expression was created.