Merged
Conversation
Future-proof for Java 21: * Avoid deprecated URL constructor * Use URI instead of String in some places to make it easier to create a URL when we need it * Avoid Thread.getId (deprecated in Java 19), and just use the Thread.toString (which includes the thread name and the thread ID) * Use URI.resolve to construct HDFS URLs in tests rather than String concatenation (must be used cautiously, due to HADOOP-19815, but still better than String concatenation) * Avoid deprecated exec method for launching umask by removing unnecessary DFS config code (default behavior is sufficient for these) * Put spotbugs and auto-service-annotations as optional compile time dependency for every module (simplifies POMs) to ensure consistent annotation processor execution Also improve the build a bit more: * Remove unused commons-vfs2-bom import dependency * Improve concurrent delete test slightly to guarantee at least one classloader per thread, and make test pass when it creates fewer classloaders than we hope (it makes as many as it can in 10 seconds, but it might not make as many as the 50 it was previously expecting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future-proof for Java 21:
Also improve the build a bit more: