Updated examples to work with Accumulo 2.0.0-alpha-1 #28
Conversation
milleruntime
left a comment
milleruntime
left a comment
There was a problem hiding this comment.
I made a comment about the examples being CLI, which reminded me we should get back to making the examples better. Maybe create follow on tickets for the classes you added CLI options.
| <groupId>commons-configuration</groupId> | ||
| <artifactId>commons-configuration</artifactId> | ||
| <version>1.6</version> | ||
| <version>1.10</version> |
There was a problem hiding this comment.
Shouldn't these deps match Accumulo? Or are we able to do better here?
There was a problem hiding this comment.
1.10 matches what Accumulo uses
| @Parameter(names = "-c") | ||
| String clientProps = "conf/accumulo-client.properties"; | ||
| } | ||
|
|
There was a problem hiding this comment.
Would be nice to get back to moving examples away from the CLI stuff but I guess its OK to just get a fix in here.
There was a problem hiding this comment.
These were added for ExamplesIT. I am OK with CLI stuff if the options are visible and in the example and not abstracted away. We could remove this if we want to stop testing the examples in ExamplesIT
There was a problem hiding this comment.
We could still have ExamplesIT that runs all the examples but does it programmatically instead of using the CLI.
2 participants
No description provided.