Merged
Conversation
ctubbsii
requested changes
Nov 9, 2022
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
You should copy the configuration from the main accumulo pom for sortpom-maven-plugin, because it has an option <spaceBeforeCloseEmptyElement>true</spaceBeforeCloseEmptyElement> that is important to keep it consistent with the behavior of the maven-release-plugin, which can rewrite the pom and add this space.
ctubbsii
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the version for several dependencies and plugins. Also, the versions of some dependencies were removed so they could be handled by the parent pom instead. The formatting changes which removed a space before the
/>was automated. All tests that were passing before these changes still pass now.