Skip to content

Create code overview page in 2.0 manual#176

Closed
mikewalch wants to merge 5 commits intoapache:masterfrom
mikewalch:code-overview
Closed

Create code overview page in 2.0 manual#176
mikewalch wants to merge 5 commits intoapache:masterfrom
mikewalch:code-overview

Conversation

@mikewalch
Copy link
Member

This should help users/developers learn code and troubleshoot issues on their own.

Making this a draft PR to get input before I finish the page.

@milleruntime
Copy link
Contributor

I like this idea! We could also update this page, simplify it a bit: https://accumulo.apache.org/contributors-guide/

* Describes Accumulo design and links to relevant
  sections of the code.
@mikewalch mikewalch marked this pull request as ready for review April 29, 2019 19:45
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of this page... but I'm worried about the increased amount of code within our website generation. The website docs should be simple, static, and easy to maintain. The more code we add in place of static website content, the more the bar is raised, making it more difficult for others (especially non-programmers) to contribute to the documentation.

Copy link
Contributor

@keith-turner keith-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add a section for FATE

* responds to reads from clients and form a sorted merge view of all
key/value pairs from all files & memory
* perform recovery of a [Tablet] that was previously on a server that failed
and reapply any writes found in the write-ahead log to the tablet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add compactions to the list. Could also add caching and bulk import.

* [detect and respond][update] to [TabletServer] failures
* assign and balance tablets to Tablet Servers using a [TabletBalancer]
* handle table creation, alteration and deletion requests from clients using the [TableManager]
* coordinate changes to write-ahead logs using the [WalStateManager].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be more specific. It coordinates sorting of WALs and associates WALs to tablets that need them (tablets that were previously assigned to a dead tserver) before assigning.

@keith-turner
Copy link
Contributor

The more code we add in place of static website content, the more the bar is raised, making it more difficult for others (especially non-programmers) to contribute to the documentation.

It may raise the bar for contributing to the website, but I think its worthwhile if it results in a more productive experience for users. W/o the new automation I would not create many links that I now create because it would be too cumbersome. I think these links are beneficial to the user.

@milleruntime
Copy link
Contributor

@mikewalch any plans to complete this? If not, I will just close this for now since you were championing for it. We can always open another PR in the future if you pick it back up.

@mikewalch mikewalch closed this Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants