Skip to content

Updates to 1.9.0 release notes#77

Merged
mikewalch merged 3 commits intoapache:masterfrom
mikewalch:1.9.0-notes
Apr 17, 2018
Merged

Updates to 1.9.0 release notes#77
mikewalch merged 3 commits intoapache:masterfrom
mikewalch:1.9.0-notes

Conversation

@mikewalch
Copy link
Copy Markdown
Member

This PR does not publish the release notes or make them complete. More work needs to be done.

draft: true
---

Apache Accumulo 1.9.0 is a minor release on the 1.x branch. This release would be considered a maintainence release on 1.8
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are quite long for GitHub's code review screen. I think they are wrapping at 125 chars or so. Our standard 100 char line limit, or even something more conservative, like the 72 chars for standard email text wrapping, would make these easier to read and review.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. see b004a9c

---

Apache Accumulo 1.9.0 is a minor release on the 1.x branch. This release would be considered a maintainence release on 1.8
branch except there are some API additions and performance improvements which resulted in a new minor release. Users of 1.8.x
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the API addition contributed to the minor release version bump, because only that is covered by Semver. Mentioning the performance imnprovements isn't relevant here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the text. see b004a9c

Apache Accumulo 1.9.0 is a minor release on the 1.x branch. This release would be considered a maintainence release on 1.8
branch except there are some API additions and performance improvements which resulted in a new minor release. Users of 1.8.x
versions of Accumulo should upgrade to 1.9.0. There will be no more bug fix releases on the 1.8 branch. This release contains
changes from 93 issues. [A list of all changes](#all-changes) in this release is available at the bottom of this page.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike the "all changes" list being included in the release notes. It is reminiscent of the old CHANGES file that was too long and spammy to be useful, and duplicates the issue tracker and the git log's role, which is where a user can go if they really are interested in all the changes.

The release notes should just be a summary of the most important, most relevant, stuff for transitioning to this new release.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left all changes in until the release notes are finished but I marked that they should be removed.


### Performance Improvements

Several peformance improvements were added in [#379], [ACCUMULO-4778], [ACCUMULO-4779] and [ACCUMULO-4781].
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know we could use # in the markdown links. Nice 😺

@keith-turner
Copy link
Copy Markdown
Contributor

Whats there looks good. I would like to make some changes when you are finished.

@mikewalch mikewalch merged commit 24a174f into apache:master Apr 17, 2018
@mikewalch mikewalch deleted the 1.9.0-notes branch April 17, 2018 19:44
asfgit pushed a commit that referenced this pull request Apr 17, 2018
Updates to 1.9.0 release notes (#77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants